Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

midori: add adwaita-icon-theme for fallback #75065



Copy link

@matthewbauer matthewbauer commented Dec 5, 2019

Otherwise we get lots of missing icons.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
Notify maintainers

cc @

Otherwise we get lots of missing icons.
Copy link

@worldofpeace worldofpeace commented Dec 5, 2019

See Icons
We'd prefer if users just installed an icon theme.

Might need to find our threads for reference.

cc/ @jtojnar

Copy link

@jtojnar jtojnar commented Dec 5, 2019

We discussed it in the GNOME docs PR

Copy link
Member Author

@matthewbauer matthewbauer commented Dec 5, 2019

Alright. I did have a theme but it looks like it was the KDE breeze theme which doesn't seem to work with midori. Adding gnome3.adwaita-icon-theme to environment.systemPackages fixes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.