Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statserial: init at 1.1 #75073

Merged
merged 2 commits into from Apr 20, 2020
Merged

statserial: init at 1.1 #75073

merged 2 commits into from Apr 20, 2020

Conversation

@robertseaton
Copy link
Contributor

@robertseaton robertseaton commented Dec 6, 2019

Motivation for this change

Adds statserial package. Changes were already reviewed but I somehow blew away the pull request while trying to squash it into one commit.

Tested with USB serial device and native serial port on linux-x86_64.

cc @stigtsp

Things done
  • [ x ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • [ x ] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • [ x ] Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • [ x ] Ensured that relevant documentation is up to date
  • [ x ] Fits CONTRIBUTING.md.
Notify maintainers

cc @

Copy link
Member

@stigtsp stigtsp left a comment

Looks good to me

@etu etu merged commit f32e75c into NixOS:master Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.