Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gopher: 3.0.11 -> 3.0.17 #75090

Merged
merged 1 commit into from Dec 8, 2019
Merged

gopher: 3.0.11 -> 3.0.17 #75090

merged 1 commit into from Dec 8, 2019

Conversation

@jonringer
Copy link
Contributor

@jonringer jonringer commented Dec 6, 2019

Motivation for this change

noticed it was out of date in @r-ryantm logs

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

[1 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/75090
1 package were built:
gopher
@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Dec 6, 2019

@GrahamcOfBorg build gopher

Copy link
Member

@sternenseemann sternenseemann left a comment

Builds and works fine, package implementation cleaner 👍

@Ma27
Ma27 approved these changes Dec 6, 2019
Copy link
Member

@Ma27 Ma27 left a comment

Built and tested locally. Before merging, it would be cool if you could either look into th edarwin build issue or exclude the platform :)

@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Dec 6, 2019

I did, the issue is that they have a local file called regex.h which is colliding with the std regex.h

@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Dec 6, 2019

for some reason, gcc will resolve it correct, but clang crashes and burns (which is appropriate)

@Ma27
Copy link
Member

@Ma27 Ma27 commented Dec 6, 2019

Is there an upstream bugreport? (or probably even a patch?) :)

@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Dec 6, 2019

don't think so, I don't think there's been any real activity in 2 years on gopher. Also the previous gopher.x86_64-darwin build was failing https://hydra.nixos.org/eval/1558523?filter=gopher&compare=1558502&full=

I think I'm just going to mark this as linux only

@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Dec 6, 2019

other option is to do stdenv = gccStdenv

@jonringer jonringer force-pushed the jonringer:bump-gopher branch from 7dc8215 to a42ff25 Dec 7, 2019
@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Dec 7, 2019

@GrahamcOfBorg build gopher

@ofborg ofborg bot added the 8.has: clean-up label Dec 7, 2019
@ofborg ofborg bot requested a review from sternenseemann Dec 7, 2019
@jonringer jonringer merged commit bd6c0ce into NixOS:master Dec 8, 2019
16 checks passed
16 checks passed
gopher on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
gopher on aarch64-linux Success
Details
gopher on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@jonringer jonringer deleted the jonringer:bump-gopher branch Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.