Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`lib.strings.intersperse` -> `lib.lists.intersperse`. #75101

Closed
wants to merge 1 commit into from

Conversation

@pinktrink
Copy link
Contributor

@pinktrink pinktrink commented Dec 6, 2019

intersperse is defined within lib.strings yet does not work for
string, only lists. Furthermore, it only returns a list. There is no
sense in a function that only works with lists being in the strings
library.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@pinktrink pinktrink requested review from edolstra and nbp as code owners Dec 6, 2019
`intersperse` is defined within `lib.strings` yet does not work for
strings, only lists. Furthermore, it only returns a list. There is no
sense in a function that only works with lists being in the strings
library.
@pinktrink pinktrink force-pushed the pinktrink:master branch from 20e43f0 to 2dc54a6 Dec 6, 2019
@pinktrink pinktrink closed this Dec 6, 2019
@pinktrink pinktrink reopened this Dec 6, 2019
@pinktrink pinktrink closed this Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.