Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`lib.strings.intersperse` -> `lib.lists.intersperse`. #75102

Open
wants to merge 1 commit into
base: master
from

Conversation

@pinktrink
Copy link
Contributor

@pinktrink pinktrink commented Dec 6, 2019

intersperse is defined within lib.strings yet does not work for
strings, only lists. Furthermore, it only returns a list. There is no
sense in a function that only works with lists being in the strings
library.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@pinktrink pinktrink requested review from edolstra and nbp as code owners Dec 6, 2019
@d-goldin
Copy link
Contributor

@d-goldin d-goldin commented Dec 6, 2019

@pinktrink pinktrink force-pushed the pinktrink:master branch from 2dc54a6 to f549d2c Dec 6, 2019
@pinktrink
Copy link
Contributor Author

@pinktrink pinktrink commented Dec 6, 2019

Done.

@pinktrink
Copy link
Contributor Author

@pinktrink pinktrink commented Dec 6, 2019

Another issue has popped up. Let me run this one through the ringer until I have a passing build.

@pinktrink pinktrink force-pushed the pinktrink:master branch from f549d2c to 29e93ef Dec 6, 2019
@pinktrink pinktrink force-pushed the pinktrink:master branch from 29e93ef to 44e6bec Dec 6, 2019
@pinktrink pinktrink force-pushed the pinktrink:master branch 4 times, most recently from 42835c4 to 852a120 Dec 6, 2019
@pinktrink
Copy link
Contributor Author

@pinktrink pinktrink commented Dec 6, 2019

There we go. This branch is ready for merging.

lib/strings.nix Outdated Show resolved Hide resolved
@pinktrink pinktrink force-pushed the pinktrink:master branch 3 times, most recently from 1b44fca to c1b3498 Dec 7, 2019
`intersperse` is defined within `lib.strings` yet does not work for
sintersperse trings, only lists. Furthermore, it only returns a list. There is no
sense in a function that only works with lists being in the strings
library.
@pinktrink pinktrink force-pushed the pinktrink:master branch from c1b3498 to 8527821 Dec 7, 2019
@@ -54,9 +54,10 @@ rec {
separator:
# Input list
list:
if list == [] || length list == 1
lib.warn "`lib.strings.intersperse' is deprecated and will be removed. Please use `lib.lists.intersperse'."

This comment has been minimized.

@pinktrink

pinktrink Dec 8, 2019
Author Contributor

@d-goldin How is this?

This comment has been minimized.

@d-goldin

d-goldin Dec 10, 2019
Contributor

Maybe just call lib.lists.intersperse directly here instead of duplicating the logic? A dependency on lib.lists already exists anyways below.

Edit: To clarify, I mean intersperse = lib.warn "deprecated" lib.lists.intersperse directly - or did I miss something?

This comment has been minimized.

@pinktrink

pinktrink Dec 15, 2019
Author Contributor

Oh, good call, that was a moment of stupidity. I'll fix that.

@stale
Copy link

@stale stale bot commented Jun 12, 2020

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse.
  3. Ask on the #nixos channel on irc.freenode.net.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.