Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openafs_1_8: 1.8.3 -> 1.8.5 #75104

Merged
merged 1 commit into from Dec 7, 2019
Merged

openafs_1_8: 1.8.3 -> 1.8.5 #75104

merged 1 commit into from Dec 7, 2019

Conversation

@andersk
Copy link
Contributor

@andersk andersk commented Dec 6, 2019

Motivation for this change

Addresses security advisories OPENAFS-SA-2019-001, OPENAFS-SA-2019-002, OPENAFS-SA-2019-003.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @maggesi @spacefrogg

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Copy link
Contributor

@spacefrogg spacefrogg left a comment

Is the cross-build patch official? Is there an upstream commit addressing this issue?

Looks good otw!

@andersk
Copy link
Contributor Author

@andersk andersk commented Dec 7, 2019

No, it’s the same patch that you added in #48571, I just tweaked the diff context so it still applies. It looks like you submitted it at https://gerrit.openafs.org/13359, where upstream is still waiting for you to fix the CentOS BuiltBot failure and address their feedback.

@veprbl
veprbl approved these changes Dec 7, 2019
Copy link
Member

@veprbl veprbl left a comment

Passes nix-review on x86_64-linux (NixOS, with sandboxing)

2 package are marked as broken and were skipped:
linuxPackages_hardkernel_4_14.openafs_1_8 linuxPackages_hardkernel_latest.openafs_1_8

4 package failed to build:
linuxPackages_hardened.openafs_1_8 linuxPackages_latest-libre.openafs_1_8 linuxPackages_latest_hardened.openafs_1_8 linuxPackages_testing_hardened.openafs_1_8

11 package were build:
linuxPackages-libre.openafs_1_8 linuxPackages.openafs_1_8 linuxPackages_4_14.openafs_1_8 linuxPackages_4_4.openafs_1_8 linuxPackages_4_9.openafs_1_8 linuxPackages_5_3.openafs_1_8 linuxPackages_5_4.openafs_1_8 linuxPackages_latest_xen_dom0.openafs_1_8 linuxPackages_testing_bcachefs.openafs_1_8 linuxPackages_xen_dom0.openafs_1_8 openafs_1_8
@veprbl veprbl merged commit b661db1 into NixOS:master Dec 7, 2019
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
openafs_1_8 on aarch64-linux Success
Details
openafs_1_8 on x86_64-linux Success
Details
@veprbl veprbl self-assigned this Dec 7, 2019
peterhoeg added a commit to peterhoeg/nixpkgs that referenced this pull request Dec 9, 2019
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
@andersk andersk deleted the andersk:openafs-1.8.5 branch Dec 10, 2019
veprbl added a commit that referenced this pull request Feb 4, 2020
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
(cherry picked from commit b661db1)
@veprbl veprbl removed their assignment Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.