Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

home-assistant: add zha #75111

Closed
wants to merge 5 commits into from
Closed

home-assistant: add zha #75111

wants to merge 5 commits into from

Conversation

@elseym
Copy link
Member

@elseym elseym commented Dec 6, 2019

Motivation for this change

adds the home-assistant zha-component with support for deconz hardware. tested with the ConBee II.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

elseym added 5 commits Dec 2, 2019
adds the home-assistant zha-component with support for deconz hardware
@elseym elseym requested review from FRidh and jonringer as code owners Dec 6, 2019
@ofborg ofborg bot added the 6.topic: python label Dec 6, 2019
@jonringer
Copy link
Contributor

@jonringer jonringer commented Dec 6, 2019

please fix eval errors:

zigpy-deconz/default.nix:1:1 called without required argument 'pyserial-asyncio'
zigpy = callPackage ../development/python-modules/zigpy { };

crccheck = callPackage ../development/python-modules/crccheck { };

zha-quirks = callPackage ../development/python-modules/zha-quirks { };

zigpy-deconz = callPackage ../development/python-modules/zigpy-deconz { };

Comment on lines +6596 to +6603

This comment has been minimized.

@jonringer

jonringer Dec 6, 2019
Contributor

please try to sort these

@@ -0,0 +1,24 @@
{ stdenv, buildPythonPackage, fetchPypi
, pyserial-asyncio, zigpy

This comment has been minimized.

@jonringer

jonringer Dec 6, 2019
Contributor

this doesnt exist, did you meant pytest-asyncio?

Suggested change
, pyserial-asyncio, zigpy
, pyserial-asyncio, zigpy
@etu
Copy link
Contributor

@etu etu commented Dec 7, 2019

Duplicate of #74723 ? :)

@etu etu closed this Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.