Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gnome extension workspace-grid is now workspace-matrix #75123

Merged

Conversation

@chkno
Copy link
Member

@chkno chkno commented Dec 6, 2019

Motivation for this change

Add workspace-matrix Gnome extension. Also, remove crufty, unused workspace-grid that it replaces.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @aneeshusa

@chkno chkno force-pushed the chkno:workspace-grid-is-now-workspace-matrix branch from dba72f3 to 5597400 Dec 7, 2019
@chkno chkno mentioned this pull request Dec 7, 2019
4 of 10 tasks complete
@chkno
Copy link
Member Author

@chkno chkno commented Dec 7, 2019

Oh, oops, there's another already-open PR for this: #67876. But it's stale (unresponsive for 3 months), so I guess it makes sense to continue here?

@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Dec 7, 2019

Oh, oops, there's another already-open PR for this: #67876. But it's stale (unresponsive for 3 months), so I guess it makes sense to continue here?

That's fine by me.

chkno added 2 commits Dec 6, 2019
workspace-matrix largely replaces workspace-grid [1].

Also, workspace-grid.nix was accidentally dropped from
top-level/all-packages.nix in the Gnome 3.18 -> 3.20 bump in
5a245c2, so this file has been
unreferenced for three years.

[1] zakkak/workspace-grid#120 (comment)
@chkno chkno force-pushed the chkno:workspace-grid-is-now-workspace-matrix branch from 5597400 to 492de5c Dec 8, 2019
@chkno chkno requested review from worldofpeace and jtojnar Dec 16, 2019
Copy link
Member

@worldofpeace worldofpeace left a comment

LGTM. works.

@worldofpeace worldofpeace merged commit 77d0815 into NixOS:master Dec 17, 2019
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
gnomeExtensions.workspace-matrix on aarch64-linux Success
Details
gnomeExtensions.workspace-matrix on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Dec 17, 2019

Huh, I don't think workspace-grid.nix was even called anywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.