Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clojure-lsp: init at release-20191223T204324 #75124

Merged
merged 1 commit into from Dec 26, 2019
Merged

Conversation

@ericdallo
Copy link
Member

@ericdallo ericdallo commented Dec 6, 2019

Motivation for this change

Add clojure-lsp derivation

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Dec 21, 2019

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-december/1711/12

@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Dec 21, 2019

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/95

@ericdallo ericdallo force-pushed the ericdallo:add-clojure-lsp branch from 716d4db to 95956b6 Dec 25, 2019
@ericdallo ericdallo changed the title clojure-lsp: init at release-20191202T142318 clojure-lsp: init at release-20191223T204324 Dec 25, 2019
@ericdallo ericdallo force-pushed the ericdallo:add-clojure-lsp branch from 95956b6 to 73b8a27 Dec 25, 2019
@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Dec 26, 2019

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/98

@marsam marsam force-pushed the ericdallo:add-clojure-lsp branch from 73b8a27 to c7d9ec5 Dec 26, 2019
@marsam
Copy link
Contributor

@marsam marsam commented Dec 26, 2019

Thank you for your contribution. I made minor changes, I hope you don't mind.
Please feel free to ping me if any PR gets stuck

@marsam
Copy link
Contributor

@marsam marsam commented Dec 26, 2019

btw, currently clojure-lsp is self-contained Java program, and relies in the Java runtime present in the user environment, maybe later we could add a wrapper with jre

@marsam marsam merged commit dce6d41 into NixOS:master Dec 26, 2019
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
clojure-lsp on aarch64-linux Success
Details
clojure-lsp on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@ericdallo
Copy link
Member Author

@ericdallo ericdallo commented Dec 26, 2019

Thank you very much @marsam, I totally agree with these future changes!

@ericdallo ericdallo deleted the ericdallo:add-clojure-lsp branch Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.