Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thunderbird: Wayland support and version bump #75143

Closed
wants to merge 2 commits into from

Conversation

@lovesegfault
Copy link
Contributor

@lovesegfault lovesegfault commented Dec 7, 2019

Motivation for this change

I noticed wayland support wasn't available, so I copied the implementation from Firefox and verified that it works. There was a version bump available, so I did that too.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @nbp @edolstra (cc. @andir since he maintains FF which is a similar build)

lovesegfault added 2 commits Dec 7, 2019
@lovesegfault
Copy link
Contributor Author

@lovesegfault lovesegfault commented Dec 7, 2019

[2 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/75143
1 package were built:
thunderbird
Copy link
Contributor

@tomberek tomberek left a comment

Builds and runs on sway [NixOS].

@lovesegfault lovesegfault mentioned this pull request Dec 9, 2019
4 of 10 tasks complete
@lovesegfault
Copy link
Contributor Author

@lovesegfault lovesegfault commented Dec 9, 2019

Superseded by #75328

@lovesegfault lovesegfault deleted the lovesegfault:thunderbird-wayland branch Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.