Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gohufont: generate opentype files #75163

Merged
merged 6 commits into from Feb 13, 2020
Merged

gohufont: generate opentype files #75163

merged 6 commits into from Feb 13, 2020

Conversation

@rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Dec 7, 2019

Motivation for this change

See #75160

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested in xterm, xfontsel and dunst
  • Tested compilation of all pkgs that depend on this change (none)
  • Tested execution of all binary files (none)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@rnhmjoj
Copy link
Contributor Author

@rnhmjoj rnhmjoj commented Dec 21, 2019

The results seems to depend on the builder OS. This is pretty bad.
I don't know how to debug this... maybe I could try to build on the community aarch64 server....

rnhmjoj added 5 commits Dec 7, 2019
@rnhmjoj rnhmjoj force-pushed the rnhmjoj:gohu branch from 4c45861 to 96606b6 Feb 7, 2020
@rnhmjoj
Copy link
Contributor Author

@rnhmjoj rnhmjoj commented Feb 7, 2020

So, the cause of the non determinism was an actual bug in fonttosfnt, which I should have fixed and reported upstream.

@rnhmjoj rnhmjoj requested a review from jtojnar Feb 8, 2020
@rnhmjoj rnhmjoj force-pushed the rnhmjoj:gohu branch 2 times, most recently from 94a7b57 to 675916f Feb 9, 2020
@rnhmjoj rnhmjoj force-pushed the rnhmjoj:gohu branch from 675916f to c5a0d66 Feb 10, 2020
@rnhmjoj rnhmjoj merged commit f8c3e15 into NixOS:master Feb 13, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
bdf2psf, gohufont, xorg.fonttosfnt on aarch64-linux Success
Details
bdf2psf, gohufont, xorg.fonttosfnt on x86_64-darwin Success
Details
bdf2psf, gohufont, xorg.fonttosfnt on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Feb 14, 2020
gohufont: generate opentype files
(cherry picked from commit f8c3e15)
@rnhmjoj rnhmjoj deleted the rnhmjoj:gohu branch Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.