Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tdb: 1.3.16 -> 1.3.18 #75167

Merged
merged 1 commit into from Dec 9, 2019
Merged

tdb: 1.3.16 -> 1.3.18 #75167

merged 1 commit into from Dec 9, 2019

Conversation

@bbigras
Copy link
Contributor

@bbigras bbigras commented Dec 7, 2019

Motivation for this change

sssd requires it when using Active Directory, otherwise we get:

[   52.702464] sssd_be[804]: Unable to load module [ad] with path [/nix/store/kcaid7ypwfk896awy5qwyvamdpqfzwd9-sssd-1.16.4/lib/sssd/libsss_ad.so]: /nix/store/7cslafmwm9qiar8yn5q227r61ycifqpi-tdb-1.3.16/lib/libtdb.so.1: version `TDB_1.3.17' not found (required by /nix/store/sm41fp80ilnshgwjj8yzs9s4v4bkpcki-samba-4.10.10/lib/libsmbconf.so.0)

Note that is not the latest version. The new one is more complex to update. It requires some python stuff. At least with 1.3.18 I can play with sssd.

I'm working on a nixos test to catch if sssd doesn't start but it will be for later.

#58380 will bring tdb to >= 1.4.0 if merged eventually.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I only tested nixos/tests/samba.nix as I wasn't able to find out other tests depending on tdb.

I did join a samba active directory (that I set up for testing) with this.

/nix/store/7cslafmwm9qiar8yn5q227r61ycifqpi-tdb-1.3.16 94.1M
/nix/store/kac47wii2ml0x62wpzcr35x40mwrfvjg-tdb-1.3.18 94.1M

Notify maintainers

cc @

@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Dec 9, 2019

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/92

@c0bw3b
c0bw3b approved these changes Dec 9, 2019
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Result of nix-review pr 75167 1

8 package were build:
  • autofs5 (gnome3.rhythmbox)
  • fdm (gnome3.rhythmbox)
  • rhythmbox (gnome3.rhythmbox)
  • ldb (gnome3.rhythmbox)
  • libchop (gnome3.rhythmbox)
  • pbis-open (gnome3.rhythmbox)
  • sssd (gnome3.rhythmbox)
  • tdb (gnome3.rhythmbox)
@c0bw3b c0bw3b merged commit 70fb3ae into NixOS:master Dec 9, 2019
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
tdb on aarch64-linux Success
Details
tdb on x86_64-linux Success
Details
@bbigras bbigras deleted the bbigras:tdb branch Dec 9, 2019
@bbigras
Copy link
Contributor Author

@bbigras bbigras commented Dec 9, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.