Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nextcloud-client: disable shibboleth #75202

Merged
merged 1 commit into from Dec 14, 2019
Merged

Conversation

@veprbl
Copy link
Member

@veprbl veprbl commented Dec 8, 2019

Motivation for this change

The expression already uses qtwebengine.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @caugner @Ma27

@veprbl veprbl mentioned this pull request Dec 8, 2019
19 of 68 tasks complete
@ofborg ofborg bot requested a review from Ma27 Dec 8, 2019
Allows to remove qtwebkit dependency
@veprbl veprbl force-pushed the veprbl:pr/nextcloud_rm_qtwebkit branch from d3d201a to 61b7d24 Dec 8, 2019
@veprbl veprbl changed the title nextcloud-client: remove unused qtwebkit dependency nextcloud-client: remove qtwebkit dependency Dec 8, 2019
@veprbl veprbl changed the title nextcloud-client: remove qtwebkit dependency nextcloud-client: disable shibboleth Dec 8, 2019
@veprbl
Copy link
Member Author

@veprbl veprbl commented Dec 8, 2019

I made a similar PR for owncloud-client: #75206
Also notice that owncloud-client upstream has removed the feature completely: owncloud/client@697b6b9

@veprbl
Copy link
Member Author

@veprbl veprbl commented Dec 8, 2019

nextcloud-clients upstream builds their images with this option:
https://github.com/nextcloud/desktop/blob/c7299dec78303a72192e1d4d666f91fe5798eae9/.drone.yml#L25

@aanderse
Copy link
Contributor

@aanderse aanderse commented Dec 8, 2019

What does shibboleth have to do with qt at all...? 🤔

@veprbl
Copy link
Member Author

@veprbl veprbl commented Dec 8, 2019

I would guess, it serves some sort of authentication form via html+http, so you need a full web browser to display it?

@aanderse
Copy link
Contributor

@aanderse aanderse commented Dec 9, 2019

Interesting. I learn something new every day. 😄

@Ma27
Ma27 approved these changes Dec 14, 2019
@Ma27
Copy link
Member

@Ma27 Ma27 commented Dec 14, 2019

aarch64 build currently fails due to qtwebengine. Apart from this, LGTM 👍

@Ma27 Ma27 merged commit ce23582 into NixOS:master Dec 14, 2019
16 checks passed
16 checks passed
nextcloud-client on aarch64-linux Failure
Details
nextcloud-client on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
nextcloud-client on x86_64-linux Success
Details
@bjornfor

This comment has been minimized.

Copy link
Contributor

@bjornfor bjornfor commented on 61b7d24 Dec 22, 2019

I don't know what shibboleth is, but I don't like the idea that nixpkgs packages should be less featureful than what upstream intends to, i.e. just let them build with their defaults. If trimming down is useful, then please add an option. By looking at this patch, think I can assume that upstream intends shibboleth to be on by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.