Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pypi2nix: 2.0.1 -> 2.0.2 #75254

Merged
merged 1 commit into from Dec 9, 2019
Merged

pypi2nix: 2.0.1 -> 2.0.2 #75254

merged 1 commit into from Dec 9, 2019

Conversation

@seppeljordan
Copy link
Contributor

@seppeljordan seppeljordan commented Dec 8, 2019

Since the source distribution of the package on pypi2nix does not contain unittests,
we removed the checkPhase command that was present in earlier versions of the package.

Motivation for this change

A new version of pypi2nix was released to PyPI. This pull request updates nixpkgs to distribute that version.

Closure size grew slightly since jsonschema was introduced as an additional dependency.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@seppeljordan seppeljordan force-pushed the seppeljordan:update-pypi2nix branch from 6e64cf2 to 22d44b6 Dec 8, 2019
Since the source distribution of the package on pypi2nix does not contain unittests,
we removed the checkPhase command that was present in earlier versions of the package.
@seppeljordan seppeljordan force-pushed the seppeljordan:update-pypi2nix branch from 22d44b6 to 65d2d58 Dec 8, 2019
Copy link
Contributor

@Lassulus Lassulus left a comment

tested with nix-review

@Lassulus Lassulus merged commit ce1760a into NixOS:master Dec 9, 2019
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
pypi2nix on aarch64-linux Success
Details
pypi2nix on x86_64-linux Success
Details
@seppeljordan
Copy link
Contributor Author

@seppeljordan seppeljordan commented Dec 9, 2019

@Lassulus thank you :)

@seppeljordan seppeljordan deleted the seppeljordan:update-pypi2nix branch Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.