Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autochanger support to bacula-sd #75285

Merged
merged 1 commit into from Dec 11, 2019
Merged

Add autochanger support to bacula-sd #75285

merged 1 commit into from Dec 11, 2019

Conversation

@wucke13
Copy link
Contributor

@wucke13 wucke13 commented Dec 8, 2019

  • Fixing interrupted descriptions
  • Added more verbose descriptions
  • Addded to the descriptions
  • uniformly reformated descriptions to break at 80 chars

(cherry picked from commit c7945c8)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Lassulus

@Lassulus
Copy link
Contributor

@Lassulus Lassulus commented Dec 8, 2019

ah, the commit message needs to change, sadly I missed that on the other PR

@wucke13 wucke13 force-pushed the wucke13:master branch from d4bd326 to 479ec39 Dec 8, 2019
@wucke13
Copy link
Contributor Author

@wucke13 wucke13 commented Dec 8, 2019

Updated this PR. Sorry.

Copy link
Contributor

@Lassulus Lassulus left a comment

LGTM
Edit: can we change the commit message to nixos/bacula-sd: add autochange support

Copy link
Contributor

@Lassulus Lassulus left a comment

can we change the commit message to nixos/bacula-sd: add autochange support

+ Fixing interrupted descriptions
+ Added more verbose descriptions
+ Addded <literal> to the descriptions
+ uniformly reformated descriptions to break at 80 chars

(cherry picked from commit c7945c8)
@wucke13 wucke13 force-pushed the wucke13:master branch from 479ec39 to 73c19cc Dec 11, 2019
@wucke13
Copy link
Contributor Author

@wucke13 wucke13 commented Dec 11, 2019

Sure, done.

@Lassulus Lassulus merged commit 93696e3 into NixOS:master Dec 11, 2019
12 checks passed
12 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.