Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matrix-synapse: Use postgres service to create database and user #75294

Merged
merged 1 commit into from Dec 14, 2019

Conversation

@kampka
Copy link
Contributor

@kampka kampka commented Dec 8, 2019

Motivation for this change

Use the postgresql service for managing database and user creation instead of rolling a custom script.
Depends on #75293

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @thoughtpolice @Ralith @corngood

@kampka kampka requested a review from thoughtpolice as a code owner Dec 8, 2019
@kampka kampka changed the title Postgres service refactor matrix-synapse: Use postgres service to create database and user Dec 8, 2019
@aanderse aanderse requested a review from Ma27 Dec 9, 2019
@kampka kampka force-pushed the kampka:postgres-service-refactor branch from 5cd3b6c to b2d67c0 Dec 13, 2019
@kampka
Copy link
Contributor Author

@kampka kampka commented Dec 13, 2019

Rebased against master with #75293 now merged, so this should now be good to go.

@Ma27 Ma27 requested a review from Ekleog Dec 14, 2019
@Ma27
Ma27 approved these changes Dec 14, 2019
@Ekleog
Ekleog approved these changes Dec 14, 2019
Copy link
Member

@Ekleog Ekleog left a comment

Looks great, thanks!

@Ekleog
Copy link
Member

@Ekleog Ekleog commented Dec 14, 2019

@ofborg build nixosTests.matrix-synapse

@kampka
Copy link
Contributor Author

@kampka kampka commented Dec 14, 2019

@Ekleog seems like the build has failed but I cannot really see why. Mind having a look?

@Ekleog
Copy link
Member

@Ekleog Ekleog commented Dec 14, 2019

The build didn't actually fail, it's just that AFAIR it's not supported on darwin :) Let's merge, then. Thank you!

@Ekleog Ekleog merged commit 226ea5c into NixOS:master Dec 14, 2019
17 checks passed
17 checks passed
nixosTests.matrix-synapse on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
matrix-synapse on aarch64-linux Success
Details
matrix-synapse on x86_64-linux Success
Details
nixosTests.matrix-synapse on aarch64-linux Success
Details
nixosTests.matrix-synapse on x86_64-linux Success
Details
@Ma27 Ma27 mentioned this pull request Feb 20, 2020
5 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.