From 2cb70571d7d792f81616cb26112c194f40680677 Mon Sep 17 00:00:00 2001 From: Tobias Mayer Date: Sun, 8 Dec 2019 22:52:08 +0100 Subject: [PATCH] kbfs: don't use store path for fusermount --- .../security/keybase/fix-paths-kbfs.patch | 48 ------------------- pkgs/tools/security/keybase/kbfs.nix | 9 +--- 2 files changed, 1 insertion(+), 56 deletions(-) delete mode 100644 pkgs/tools/security/keybase/fix-paths-kbfs.patch diff --git a/pkgs/tools/security/keybase/fix-paths-kbfs.patch b/pkgs/tools/security/keybase/fix-paths-kbfs.patch deleted file mode 100644 index 1180f38b865d79..00000000000000 --- a/pkgs/tools/security/keybase/fix-paths-kbfs.patch +++ /dev/null @@ -1,48 +0,0 @@ -diff --git a/go/kbfs/libfuse/mounter.go b/go/kbfs/libfuse/mounter.go -index d791ffc2..b116ad5d 100644 ---- a/go/kbfs/libfuse/mounter.go -+++ b/go/kbfs/libfuse/mounter.go -@@ -108,7 +108,7 @@ func (m *mounter) Unmount() (err error) { - case "darwin": - _, err = exec.Command("/sbin/umount", dir).Output() - case "linux": -- fusermountOutput, fusermountErr := exec.Command("fusermount", "-u", dir).CombinedOutput() -+ fusermountOutput, fusermountErr := exec.Command("@fusermount@", "-u", dir).CombinedOutput() - // Only clean up mountdir on a clean unmount. - if fusermountErr == nil { - m.log.Info("Successfully unmounted") -@@ -135,7 +135,7 @@ func (m *mounter) Unmount() (err error) { - "/usr/sbin/diskutil", "unmountDisk", "force", dir).Output() - case "linux": - // Lazy unmount; will unmount when KBFS is no longer in use. -- _, err = exec.Command("fusermount", "-u", "-z", dir).Output() -+ _, err = exec.Command("@fusermount@", "-u", "-z", dir).Output() - default: - err = errors.New("Forced unmount is not supported on this platform yet") - } -diff --git a/go/vendor/bazil.org/fuse/mount_linux.go b/go/vendor/bazil.org/fuse/mount_linux.go -index ec7fd89c..4d0a9e30 100644 ---- a/go/vendor/bazil.org/fuse/mount_linux.go -+++ b/go/vendor/bazil.org/fuse/mount_linux.go -@@ -196,7 +196,7 @@ func mount(dir string, conf *mountConfig, ready chan<- struct{}, _ *error) (fuse - defer readFile.Close() - - cmd := exec.Command( -- "fusermount", -+ "@fusermount@", - "-o", conf.getOptions(), - "--", - dir, -diff --git a/go/vendor/bazil.org/fuse/unmount_linux.go b/go/vendor/bazil.org/fuse/unmount_linux.go -index f02448af..6e4c6c23 100644 ---- a/go/vendor/bazil.org/fuse/unmount_linux.go -+++ b/go/vendor/bazil.org/fuse/unmount_linux.go -@@ -21,7 +21,7 @@ func unmount(dir string) error { - return sysunix.Unmount(dir, sysunix.MNT_DETACH) - } - -- cmd := exec.Command("fusermount", "-u", dir) -+ cmd := exec.Command("@fusermount@", "-u", dir) - output, err := cmd.CombinedOutput() - if err != nil { - if len(output) > 0 { diff --git a/pkgs/tools/security/keybase/kbfs.nix b/pkgs/tools/security/keybase/kbfs.nix index 93c7bd540d8a0a..9448182a65a71f 100644 --- a/pkgs/tools/security/keybase/kbfs.nix +++ b/pkgs/tools/security/keybase/kbfs.nix @@ -1,4 +1,4 @@ -{ stdenv, substituteAll, buildGoPackage, fetchFromGitHub, fuse, osxfuse, keybase }: +{ stdenv, buildGoPackage, fetchFromGitHub, keybase }: buildGoPackage { pname = "kbfs"; @@ -10,13 +10,6 @@ buildGoPackage { dontRenameImports = true; - patches = [ - (substituteAll { - src = ./fix-paths-kbfs.patch; - fusermount = "${fuse}/bin/fusermount"; - }) - ]; - buildFlags = [ "-tags production" ]; meta = with stdenv.lib; {