Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

weechat: 2.6 -> 2.7 #75307

merged 1 commit into from Dec 10, 2019

weechat: 2.6 -> 2.7 #75307

merged 1 commit into from Dec 10, 2019


Copy link

@mweinelt mweinelt commented Dec 8, 2019

Motivation for this change

New upstream release.

I disabled support for PHP and Javascript, both of which are now apparently enabled by default.

  • Javascript depends on a v8 version <= 3.24.3, and while we have 3.14 in nixpkgs it is only used by a single package and probably on the way out. Upstream issue is here: weechat/weechat#360
  • PHP wants a bunch of additional dependencies, that would somewhat increase the footprint of the derivation
    [100%] Linking C shared module
    [100%] Linking C shared module
    /nix/store/a0kdlyvbj9j4l67a8kxjr494qx6g3q0v-binutils-2.31.1/bin/ld: cannot find -lc-client
    /nix/store/a0kdlyvbj9j4l67a8kxjr494qx6g3q0v-binutils-2.31.1/bin/ld: cannot find -lzip
    /nix/store/a0kdlyvbj9j4l67a8kxjr494qx6g3q0v-binutils-2.31.1/bin/ld: cannot find -lzip
    /nix/store/a0kdlyvbj9j4l67a8kxjr494qx6g3q0v-binutils-2.31.1/bin/ld: cannot find -largon2
    /nix/store/a0kdlyvbj9j4l67a8kxjr494qx6g3q0v-binutils-2.31.1/bin/ld: cannot find -lsodium
    /nix/store/a0kdlyvbj9j4l67a8kxjr494qx6g3q0v-binutils-2.31.1/bin/ld: cannot find -lreadline
    /nix/store/a0kdlyvbj9j4l67a8kxjr494qx6g3q0v-binutils-2.31.1/bin/ld: cannot find -lpq
    /nix/store/a0kdlyvbj9j4l67a8kxjr494qx6g3q0v-binutils-2.31.1/bin/ld: cannot find -lsqlite3
    /nix/store/a0kdlyvbj9j4l67a8kxjr494qx6g3q0v-binutils-2.31.1/bin/ld: cannot find -lpq
    /nix/store/a0kdlyvbj9j4l67a8kxjr494qx6g3q0v-binutils-2.31.1/bin/ld: cannot find -lldap
    /nix/store/a0kdlyvbj9j4l67a8kxjr494qx6g3q0v-binutils-2.31.1/bin/ld: cannot find -llber
    /nix/store/a0kdlyvbj9j4l67a8kxjr494qx6g3q0v-binutils-2.31.1/bin/ld: cannot find -lpam
    /nix/store/a0kdlyvbj9j4l67a8kxjr494qx6g3q0v-binutils-2.31.1/bin/ld: cannot find -lpng
    /nix/store/a0kdlyvbj9j4l67a8kxjr494qx6g3q0v-binutils-2.31.1/bin/ld: cannot find -ljpeg
    collect2: error: ld returned 1 exit status
    make[2]: *** [src/plugins/php/CMakeFiles/php.dir/build.make:101: src/plugins/php/] Error 1
    make[1]: *** [CMakeFiles/Makefile2:1239: src/plugins/php/CMakeFiles/php.dir/all] Error 2
    make[1]: *** Waiting for unfinished jobs....
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
Notify maintainers

cc @lovek323 @the-kenny @lheckemann @Ma27

Disables support for Javascript and PHP:
- Javascript requires an old version of v8
- PHP requires a larger number of dependencies in addition to php-embed

Changelog [1]:

  New features
    - core: add option weechat.look.nick_color_hash_salt to shuffle nick colors (issue #635)
    - core: add different icons sizes (16x16 to 512x512) (issue #1347)
    - core: add file weechat.desktop
    - core: add reverse of string for screen in evaluation of expressions with "revscr:"
    - core: add length of string (number of chars and on screen) in evaluation of expressions with "length:xxx" and "lengthscr:xxx"
    - core: add calculation of expression in evaluation of expressions with "calc:xxx" (issue #997)
    - core: add optional default path (evaluated) in completion "filename"
    - core: add support of modifiers in evaluation of expressions with "modifier:name,data,string"
    - api: add modifier "color_encode_ansi" (issue #528)
    - api: add modifier "eval_path_home"
    - irc: add filters on raw buffer (issue #1000)
    - irc: add option irc.look.display_pv_warning_address to display a warning in private buffer if the remote nick address has changed (issue #892)
    - irc: add server option "ssl_password" (issue #115, issue #1416)
    - irc: add "user" in output of irc_message_parse (issue #136)
    - irc: add options irc.color.message_kick and irc.color.reason_kick (issue #683, issue #684)
    - logger: add option logger.file.color_lines (issue #528, issue #621)
    - script: add options "-ol" and "-il" in command "/script list" to send translated string with list of scripts loaded, display "No scripts loaded" if no scripts are loaded
    - xfer: add option xfer.file.download_temporary_suffix with default value ".part" (issue #1237)

  Bug fixes
    - core: set buffer name, short name and title only if the value has changed
    - core: fix scrolling up in bare mode when switched to bare mode at the top of the buffer (issue #899, issue #978)
    - core: optimize load of configuration files
    - core: fix window separators not respecting window splits (issue #630)
    - core: fix cursor mode info when prefix_align is none and with words split across lines (issue #610, issue #617, issue #619)
    - core: add support of reverse video in ANSI color codes
    - core: fixed segfault during excessive evaluation in function string_repeat (issue #1400)
    - buflist: fix extra spaces between buffers when conditions are used to hide buffers (regression introduced in version 2.6) (issue #1403)
    - irc: do not automatically open a channel with name "0" (issue #1429)
    - irc: remove option, add server option "charset_message" to control which part of the IRC message is decoded/encoded to the target charset (issue #832)
    - irc: use path from option xfer.file.upload_path to complete filename in command "/dcc send" (issue #60)
    - logger: fix write in log file if it has been deleted or renamed (issue #123)
    - python: send "bytes" instead of "str" to callbacks in Python 3 when the string is not UTF-8 valid (issue #1389)
    - relay: send message "_buffer_title_changed" to clients only when the title is changed
    - xfer: fix memory leak when a xfer is freed and when the plugin is unloaded

    - unit: add tests on GUI color functions

    - core: fix build on Haiku (issue #1420)
    - core: fix build on Alpine
    - core: remove file FindTCL.cmake
    - core: display an error on missing dependency in CMake (issue #916, issue #956)
    - debian: disable Javascript plugin on Debian Sid and Ubuntu Eoan
    - debian: build with Guile 2.2
    - guile: add support of Guile 2.2, disable /guile eval (issue #1098)
    - python: add detection of Python 3.8

marsam approved these changes Dec 9, 2019
Copy link

@Lassulus Lassulus left a comment

tested with nix-review, works fine

@lheckemann lheckemann merged commit 963e635 into NixOS:master Dec 10, 2019
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
grahamcofborg-eval ^.^!
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
grahamcofborg-eval-check-meta config.nix: checkMeta = true
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
grahamcofborg-eval-package-list nix-env -qa --json --file .
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
weechat on aarch64-linux Success
weechat on x86_64-linux Success
@mweinelt mweinelt deleted the mweinelt:weechat_2.7 branch Dec 10, 2019
Copy link

@eli-schwartz eli-schwartz commented Dec 15, 2019

Incidentally, php and javascript aren't "suddenly enabled by default". This hit archlinux too, and the actual cause is weechat/weechat@bff40e4 which caused optional dependencies which are switched on by default, to raise a fatal error instead of being disabled if their required build dependencies are missing.

You can go take a look here to see whether the two *.js scripts and completely nonexistent *.php scripts are worth supporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.