Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mbedtls_1_3, alienfx, coprthr, firestr #75310

Merged
merged 4 commits into from Dec 9, 2019

Conversation

@c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Dec 8, 2019

Motivation for this change
  • mbedtls_1_3 has been end of life for a while, we don't need it in nixpkgs anymore after #74043
    cc @fpletz

  • alienfx upstream doesn't exist anymore (reported by Repology)
    cc @tomberek

  • coprthr has been marked broken for ~5 years (and upstream released a new major version since)
    cc @thoughtpolice

  • firestr has been marked broken for ~4 years
    cc @ehmry

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
c0bw3b added 4 commits Dec 8, 2019
Upstream is gone
It's been marked as broken for 5 years
It's been marked as broken for 4 years
@c0bw3b c0bw3b added this to To do in Picking up garbage via automation Dec 8, 2019
@c0bw3b c0bw3b moved this from To do to In progress in Picking up garbage Dec 8, 2019
Copy link
Contributor

@tomberek tomberek left a comment

Very cool. I like the idea of cleaning up old/broken packages. I'll approve the alienfx portion.

@ehmry
ehmry approved these changes Dec 9, 2019
@fpletz
fpletz approved these changes Dec 9, 2019
@fpletz fpletz merged commit 8bad6c4 into NixOS:master Dec 9, 2019
12 checks passed
12 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Picking up garbage automation moved this from In progress to Done Dec 9, 2019
@c0bw3b c0bw3b deleted the c0bw3b:rem/mbed13-alienfx-coprthr-firestr branch Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.