Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildSkawarePackage: pass through extra args #75322

Merged
merged 1 commit into from Dec 16, 2019

Conversation

@alyssais
Copy link
Member

@alyssais alyssais commented Dec 9, 2019

Motivation for this change

This allows things like hooks other than postInstall to be passed
through to mkDerivation, which is very useful when customising or
debugging a package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @pmahoney

This allows things like hooks other than postInstall to be passed
through to mkDerivation, which is very useful when customising or
debugging a package.
@alyssais alyssais requested a review from Profpatsch Dec 9, 2019
@alyssais alyssais merged commit a506532 into NixOS:master Dec 16, 2019
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@alyssais alyssais deleted the alyssais:buildSkawarePackage-args branch Dec 16, 2019
@Profpatsch
Copy link
Member

@Profpatsch Profpatsch commented Dec 20, 2019

Not a fan.

@alyssais
Copy link
Member Author

@alyssais alyssais commented Dec 22, 2019

@Profpatsch
Copy link
Member

@Profpatsch Profpatsch commented Dec 22, 2019

What do you propose instead?

Thinking about it, maybe it’s the best way

@alyssais
Copy link
Member Author

@alyssais alyssais commented Dec 22, 2019

@Profpatsch
Copy link
Member

@Profpatsch Profpatsch commented Mar 22, 2020

I think I’m gonna revert this, because if you are debugging you can just add the extra argument to buildSkawarePackage proper or use overrideDerivation to add it after the fact.

e.g. outputs wasn’t added and meta has strange semantics now.

@Profpatsch
Copy link
Member

@Profpatsch Profpatsch commented Mar 22, 2020

reverted as part of #83162

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.