Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vaapiIntel: unstable-20190211 -> 2.4.0 #75342

Merged
merged 1 commit into from Dec 15, 2019
Merged

Conversation

@colemickens
Copy link
Member

@colemickens colemickens commented Dec 9, 2019

Motivation for this change

After 10+ months, Intel cut a new release of intel-vaapi-driver so we can get back to a stable release in nixpkgs.

See: intel/intel-vaapi-driver#449

BTW: Why are this and other related packaged named so weirdly? vaapiIntel vs intel-vaapi-driver? I'm more accustomed to seeing package names in nixpkgs follow their upstream package names?

NOTE: As much as I want to trust Intel, I haven't tested this myself so I can't vouch for this yet. I'll move this out of Draft when I get a chance to test it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@colemickens colemickens changed the title vaapiIntel: unstable-20190211 -> 2.4.0 DRAFT: vaapiIntel: unstable-20190211 -> 2.4.0 Dec 9, 2019
@colemickens colemickens changed the title DRAFT: vaapiIntel: unstable-20190211 -> 2.4.0 vaapiIntel: unstable-20190211 -> 2.4.0 Dec 9, 2019
@colemickens
Copy link
Member Author

@colemickens colemickens commented Dec 9, 2019

I'm using Iris right now, but this works fine. Should be good to merge.

@emmanuelrosa
Copy link
Contributor

@emmanuelrosa emmanuelrosa commented Dec 10, 2019

It works for me.

vainfo
libva info: VA-API version 1.5.0
libva info: va_getDriverName() returns 0
libva info: Trying to open /run/opengl-driver/lib/dri/i965_drv_video.so
libva info: Found init function __vaDriverInit_1_5
libva info: va_openDriver() returns 0
vainfo: VA-API version: 1.5 (libva 2.4.0)
vainfo: Driver version: Intel i965 driver for Intel(R) Ivybridge Mobile - 2.4.0
vainfo: Supported profile and entrypoints
      VAProfileMPEG2Simple            :	VAEntrypointVLD
      VAProfileMPEG2Simple            :	VAEntrypointEncSlice
      VAProfileMPEG2Main              :	VAEntrypointVLD
      VAProfileMPEG2Main              :	VAEntrypointEncSlice
      VAProfileH264ConstrainedBaseline:	VAEntrypointVLD
      VAProfileH264ConstrainedBaseline:	VAEntrypointEncSlice
      VAProfileH264Main               :	VAEntrypointVLD
      VAProfileH264Main               :	VAEntrypointEncSlice
      VAProfileH264High               :	VAEntrypointVLD
      VAProfileH264High               :	VAEntrypointEncSlice
      VAProfileH264StereoHigh         :	VAEntrypointVLD
      VAProfileVC1Simple              :	VAEntrypointVLD
      VAProfileVC1Main                :	VAEntrypointVLD
      VAProfileVC1Advanced            :	VAEntrypointVLD
      VAProfileNone                   :	VAEntrypointVideoProc
      VAProfileJPEGBaseline           :	VAEntrypointVLD

I tested it with vlc configured to use OpenGL:

VLC media player 3.0.8 Vetinari (revision 3.0.8-0-gf350b6b5a7)
[00000000007b6320] dummy interface: using the dummy interface module...
libva info: VA-API version 1.5.0
libva info: va_getDriverName() returns 0
libva info: Trying to open /run/opengl-driver/lib/dri/i965_drv_video.so
libva info: Found init function __vaDriverInit_1_5
libva info: va_openDriver() returns 0
[00007fb3c4cf3360] avcodec decoder: Using Intel i965 driver for Intel(R) Ivybridge Mobile - 2.4.0 for hardware decoding

@marsam marsam merged commit e87cfa0 into NixOS:master Dec 15, 2019
15 checks passed
15 checks passed
vaapiIntel on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
vaapiIntel on x86_64-linux Success
Details
@marsam
Copy link
Contributor

@marsam marsam commented Dec 15, 2019

Thank you @colemickens, and @emmanuelrosa

@colemickens colemickens deleted the colemickens:nixpkgs-va branch Jan 30, 2020
@NilsIrl
Copy link
Contributor

@NilsIrl NilsIrl commented Feb 6, 2020

@colemickens you should probably close intel/intel-vaapi-driver#449

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.