Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mumble: build with pulseaudio support on linux and add petabyteboy to maintainers #75358

Merged
merged 2 commits into from Dec 14, 2019

Conversation

@petabyteboy
Copy link
Member

@petabyteboy petabyteboy commented Dec 9, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

petabyteboy added 2 commits Dec 9, 2019
Most users on Linux will want to have pulseaudio support in their mumble
installations, and this way they don't have to recompile mumble with
pulseaudio support.
@c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Dec 14, 2019

@GrahamcOfBorg test mumble

@c0bw3b
c0bw3b approved these changes Dec 14, 2019
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Result of nix-review pr 75358 1

1 package failed to build:
  • mumble_overlay
4 package were build:
  • ioquake3
  • mumble
  • murmur
  • quake3demo

mumble_overlay already failing on Hydra

@c0bw3b c0bw3b merged commit fc199f5 into NixOS:master Dec 14, 2019
17 checks passed
17 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
mumble on aarch64-linux Success
Details
mumble on x86_64-linux Success
Details
tests.mumble on aarch64-linux Success
Details
tests.mumble on x86_64-linux Success
Details
@c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Dec 14, 2019

@petabyteboy small log excerpt from mumble_overlay failure:

@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking sources
unpacking source archive /nix/store/l4awgg974xkfpcrpf4g8fnjsap89wmp3-source
source root is source
@nix { "action": "setPhase", "phase": "installPhase" }
installing
ln: failed to create symbolic link './libmumble.so.1': File exists

It's been failing on Hydra since october. No idea what this second derivation is for. Maybe it isn't needed anymore?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.