Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scryer-prolog: init at 0.8.127 #75395

Open
wants to merge 2 commits into
base: master
from
Open

Conversation

@malbarbo
Copy link
Contributor

@malbarbo malbarbo commented Dec 9, 2019

Motivation for this change

A modern prolog interpreter.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@stale
Copy link

@stale stale bot commented Jun 6, 2020

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse.
  3. Ask on the #nixos channel on irc.freenode.net.
@stale stale bot added the 2.status: stale label Jun 6, 2020
@malbarbo
Copy link
Contributor Author

@malbarbo malbarbo commented Jun 8, 2020

Still important to me.

@stale stale bot removed the 2.status: stale label Jun 8, 2020
pkgs/development/compilers/scryer-prolog/default.nix Outdated Show resolved Hide resolved
maintainers/maintainer-list.nix Show resolved Hide resolved
@malbarbo malbarbo force-pushed the malbarbo:scryer-prolog branch from 677238d to 24e2e4f Sep 25, 2020
@malbarbo malbarbo changed the title scryer-prolog: init at 0.8.117-dev scryer-prolog: init at 0.8.127 Sep 25, 2020
@ryantm
ryantm approved these changes Sep 25, 2020
@ryantm
Copy link
Member

@ryantm ryantm commented Sep 25, 2020

Result of nixpkgs-review pr 75395 1

1 package built:
- scryer-prolog
Copy link
Member

@ryantm ryantm left a comment

Looking good, just need one more comment!

};

cargoSha256 = "0pc8j7b3mpn0q11mqx7icrqfrh05lvik4xq43qpgk8w7lf59hqqy";
cargoPatches = [ ./cargo.patch ];

This comment has been minimized.

@ryantm

ryantm Sep 25, 2020
Member

Can you add a comment here about why the patch is needed, hopefully with a reference to an upstream PR/issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.