Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

muse: Use wrapQtAppsHook #75405

Merged
merged 1 commit into from Jan 29, 2020
Merged

muse: Use wrapQtAppsHook #75405

merged 1 commit into from Jan 29, 2020

Conversation

@andersk
Copy link
Contributor

@andersk andersk commented Dec 10, 2019

Motivation for this change

Fixes this error:

qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""
This application failed to start because no Qt platform plugin could
be initialized. Reinstalling the application may fix this problem.

Aborted (core dumped)

Also, remove the unnecessary build input gitFull, and enable parallel building.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @volth

@teto
teto approved these changes Dec 11, 2019
@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Dec 11, 2019

Maybe just add wrapQtAppsHook instead? See #71089

@andersk
Copy link
Contributor Author

@andersk andersk commented Dec 12, 2019

My understanding is that because #71089 has not been merged yet, the Qt mkDerivation is still needed at this time to get the correct flags. If you know that I’m wrong, feel free to override me.

@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Dec 12, 2019

We were using wrapQtAppsHook to a great effect before this whole mkDerivation kerfuffle, the build should still work without the debug flag, so IMO it is better not to carry out an action we will need to undo soon.

@andersk andersk force-pushed the andersk:muse branch from f8b0a9a to 1b31571 Dec 18, 2019
@andersk
Copy link
Contributor Author

@andersk andersk commented Dec 18, 2019

an action we will need to undo soon

#71089 won’t require us to undo this; it leaves Qt mkDerivation as a compatibility wrapper. (Also “soon” is unclear to me.)

Nonetheless, in the interest of getting something done, here’s a version with wrapQtAppsHook instead. Feel free to merge either this or the Qt mkDerivation version.

@andersk andersk changed the title muse: Use qt mkDerivation muse: Use wrapQtAppsHook Dec 18, 2019
pkgs/applications/audio/muse/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/muse/default.nix Outdated Show resolved Hide resolved
@andersk andersk force-pushed the andersk:muse branch from 1b31571 to ae991e6 Dec 18, 2019
@andersk andersk requested a review from jtojnar Dec 18, 2019
Fixes this error:

qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""
This application failed to start because no Qt platform plugin could
be initialized. Reinstalling the application may fix this problem.

Aborted (core dumped)

Also, remove the unnecessary build input `gitFull`, and enable
parallel building.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
@andersk andersk force-pushed the andersk:muse branch from ae991e6 to 1bcb6fb Jan 7, 2020
@worldofpeace worldofpeace merged commit 9ef088c into NixOS:master Jan 29, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
muse on aarch64-linux Success
Details
muse on x86_64-linux Success
Details
@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Jan 29, 2020

Backported in 1dadefe

anna328p added a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.