Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maestral: 0.4.2 -> 0.6.1 #75417

Merged
merged 3 commits into from Mar 10, 2020
Merged

maestral: 0.4.2 -> 0.6.1 #75417

merged 3 commits into from Mar 10, 2020

Conversation

@peterhoeg
Copy link
Member

@peterhoeg peterhoeg commented Dec 10, 2019

Motivation for this change

Upstream is rapidly improving.

Daily driver.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

pkgs/development/python-modules/pyro5/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pyro5/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pyro5/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pyro5/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pyro5/default.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/maestral/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pyro5/default.nix Outdated Show resolved Hide resolved
sdnotify systemd
] ++ lib.optional withGui pyqt5);
sdnotify
systemd

This comment has been minimized.

@jonringer

jonringer Dec 10, 2019
Contributor

not sure if propagating theses is the right thing to do, personally I would wrap them

This comment has been minimized.

@peterhoeg

peterhoeg Mar 4, 2020
Author Member

Why?

@peterhoeg peterhoeg force-pushed the peterhoeg:u/maestral_0_4_4 branch from e8dc592 to 0eacff7 Dec 18, 2019
@peterhoeg peterhoeg force-pushed the peterhoeg:u/maestral_0_4_4 branch from 0eacff7 to b30f896 Jan 13, 2020
@peterhoeg peterhoeg changed the title maestral: 0.4.2 -> 0.4.4 maestral: 0.4.2 -> 0.5.0 Jan 13, 2020
@peterhoeg peterhoeg force-pushed the peterhoeg:u/maestral_0_4_4 branch from b30f896 to cf27667 Jan 13, 2020
@peterhoeg
Copy link
Member Author

@peterhoeg peterhoeg commented Jan 13, 2020

Thanks for your review @jonringer

@peterhoeg peterhoeg force-pushed the peterhoeg:u/maestral_0_4_4 branch 2 times, most recently from edb9b70 to b298688 Mar 4, 2020
@peterhoeg peterhoeg force-pushed the peterhoeg:u/maestral_0_4_4 branch from b298688 to 75f3ab6 Mar 4, 2020
@peterhoeg peterhoeg changed the title maestral: 0.4.2 -> 0.5.0 maestral: 0.4.2 -> 0.6.1 Mar 4, 2020
@peterhoeg peterhoeg merged commit 228ef07 into NixOS:master Mar 10, 2020
15 checks passed
15 checks passed
maestral on aarch64-linux Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
maestral on x86_64-linux Success
Details
@peterhoeg peterhoeg deleted the peterhoeg:u/maestral_0_4_4 branch Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.