Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

erlangR22: 22.1.7 -> 22.3 #75430

Merged
merged 1 commit into from Mar 29, 2020
Merged

erlangR22: 22.1.7 -> 22.3 #75430

merged 1 commit into from Mar 29, 2020

Conversation

@cw789
Copy link
Contributor

@cw789 cw789 commented Dec 10, 2019

Motivation for this change

Keeping things up-to-date.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @the-kenny @sjmackenzie @couchemar @gleber

@cw789 cw789 force-pushed the cw789:erlang_update branch 3 times, most recently from 52b0ae0 to edd95bc Jan 8, 2020
@cw789 cw789 changed the title erlangR22: 22.1.7 -> 22.2.0 erlangR22: 22.1.7 -> 22.2.1 Jan 8, 2020
@cw789 cw789 force-pushed the cw789:erlang_update branch from 31365d4 to 21ac8d2 Jan 13, 2020
@cw789 cw789 changed the title erlangR22: 22.1.7 -> 22.2.1 erlangR22: 22.1.7 -> 22.2.2 Jan 13, 2020
@cw789 cw789 force-pushed the cw789:erlang_update branch from 21ac8d2 to 1fbe102 Jan 27, 2020
@cw789 cw789 changed the title erlangR22: 22.1.7 -> 22.2.2 erlangR22: 22.1.7 -> 22.2.3 Jan 27, 2020
@cw789
Copy link
Contributor Author

@cw789 cw789 commented Jan 27, 2020

@the-kenny @sjmackenzie @gleber
Anyone up to help me to get this merged?
Quite a while I keep this PR going.

@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Feb 22, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/103

@cw789 cw789 force-pushed the cw789:erlang_update branch from 1fbe102 to a40c6c9 Feb 24, 2020
@cw789
Copy link
Contributor Author

@cw789 cw789 commented Feb 24, 2020

I've updated to the newest Erlang version once again.

@couchemar
Copy link
Contributor

@couchemar couchemar commented Feb 25, 2020

cc @the-kenny @sjmackenzie @gleber

I think we need this request merged.

@cw789 cw789 changed the title erlangR22: 22.1.7 -> 22.2.3 erlangR22: 22.1.7 -> 22.2.7 Feb 25, 2020
@cw789
Copy link
Contributor Author

@cw789 cw789 commented Feb 25, 2020

I'm open for feedback, what I can do better...

@vcunat
Copy link
Member

@vcunat vcunat commented Feb 25, 2020

Side question: is some of you still interested in R18 or R19? #80746

@cw789
Copy link
Contributor Author

@cw789 cw789 commented Feb 25, 2020

On my side as Elixir user, I would be ok with removing them...
By the way, what's the Erlang R16B02-basho.nix for?

@cw789 cw789 force-pushed the cw789:erlang_update branch from a40c6c9 to 98f6a60 Mar 17, 2020
@cw789 cw789 changed the title erlangR22: 22.1.7 -> 22.2.7 erlangR22: 22.1.7 -> 22.3 Mar 17, 2020
@cw789
Copy link
Contributor Author

@cw789 cw789 commented Mar 17, 2020

cc @the-kenny @sjmackenzie @gleber

I've updated this PR one again.
Could anybody tell me why there is currently really no progress on updating Erlang within nixpkgs?
This PR is now 4 months old.

@vcunat
Copy link
Member

@vcunat vcunat commented Mar 29, 2020

I don't really know anything about erlang, but I'd hate anything being blocked just because of non-responsive maintainers. Let's verify darwin superficially:
@GrahamcOfBorg build erlangR22

@vcunat vcunat merged commit 804477b into NixOS:master Mar 29, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
erlangR22 on aarch64-linux Success
Details
erlangR22 on x86_64-darwin Success
Details
erlangR22 on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.