Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flashplayer: 32.0.0.293 -> 32.0.0.303 #75436

Merged
merged 1 commit into from Dec 25, 2019
Merged

Conversation

@taku0
Copy link
Contributor

@taku0 taku0 commented Dec 10, 2019

Motivation for this change
  • Bug fixes.

https://helpx.adobe.com/flash-player/release-note/fp_32_air_32_release_notes.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Only tested with firefox-esr, chromium, and standalone versions.
Firefox 71 does not recognize flash plugins. It is not shown in about:plugins. Neither 32.0.0.293 nor 32.0.0.303 works. Neither firefox-bin nor firefox recognize the plugin. firefox-esr 68.3.0esr works fine with 32.0.0.303.
My old nix-env generation with flashplayer 32.0.0.270 and firefox-bin 70.0.1 work as expected.

Notify maintainers

cc @

@taku0
Copy link
Contributor Author

@taku0 taku0 commented Dec 10, 2019

I cannot find other people experiencing the issue as far as I searched quickly on Google and the Bugzilla. Is it specific to my environment, or specific to nix?

@kamilchm
Copy link
Member

@kamilchm kamilchm commented Dec 18, 2019

Same for me. No flash plugin in firefox. I'm on NixOS.

@marsam marsam merged commit 3efe39d into NixOS:master Dec 25, 2019
15 checks passed
15 checks passed
flashplayer on aarch64-linux No attempt
Details
flashplayer on x86_64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@marsam
Copy link
Contributor

@marsam marsam commented Dec 25, 2019

Thanks!

@taku0
Copy link
Contributor Author

@taku0 taku0 commented Jan 31, 2020

Related: #76943

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.