Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ueberzug: init at 18.1.5 #75442

Merged
merged 1 commit into from Dec 26, 2019
Merged

ueberzug: init at 18.1.5 #75442

merged 1 commit into from Dec 26, 2019

Conversation

@Br1ght0ne
Copy link
Contributor

@Br1ght0ne Br1ght0ne commented Dec 10, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

@Br1ght0ne Br1ght0ne force-pushed the Br1ght0ne:ueberzug-18.1.5 branch from 413768d to e39f31b Dec 11, 2019
@Br1ght0ne Br1ght0ne requested a review from jonringer Dec 11, 2019
@Br1ght0ne Br1ght0ne force-pushed the Br1ght0ne:ueberzug-18.1.5 branch from e39f31b to 0f7b115 Dec 19, 2019
@Br1ght0ne Br1ght0ne requested a review from jonringer Dec 19, 2019
@Br1ght0ne Br1ght0ne force-pushed the Br1ght0ne:ueberzug-18.1.5 branch from 0f7b115 to b769e33 Dec 26, 2019
@Br1ght0ne
Copy link
Contributor Author

@Br1ght0ne Br1ght0ne commented Dec 26, 2019

Thanks @Lassulus!

@Br1ght0ne Br1ght0ne requested a review from Lassulus Dec 26, 2019
Copy link
Contributor

@jonringer jonringer left a comment

diff LGTM
executable seems to work

[1 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/75442
2 package were built:
ueberzug python38Packages.ueberzug
@jonringer
Copy link
Contributor

@jonringer jonringer commented Dec 26, 2019

@GrahamcOfBorg build ueberzug python38Packages.ueberzug

Copy link
Contributor

@Lassulus Lassulus left a comment

tested with nix-review

@Lassulus Lassulus merged commit debc253 into NixOS:master Dec 26, 2019
19 checks passed
19 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
python38Packages.ueberzug, ueberzug on aarch64-linux Success
Details
python38Packages.ueberzug, ueberzug on x86_64-darwin Success
Details
python38Packages.ueberzug, ueberzug on x86_64-linux Success
Details
ueberzug on aarch64-linux Success
Details
ueberzug on x86_64-darwin Success
Details
ueberzug on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.