Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc/gnome: update wrapper args example, remove proliferated uses #75465

Merged
merged 2 commits into from Dec 15, 2019

Conversation

@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Dec 10, 2019

Motivation for this change

#75443

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

It now breaks down as mentioned in #75443
@worldofpeace
Copy link
Member Author

@worldofpeace worldofpeace commented Dec 11, 2019

Thanks for suggestions, will commit.

@worldofpeace worldofpeace force-pushed the worldofpeace:gnome-args branch from 4936bb7 to 1a335e5 Dec 11, 2019
@worldofpeace worldofpeace requested a review from jtojnar Dec 11, 2019
Copy link
Contributor

@jtojnar jtojnar left a comment

Looks good otherwise

Co-Authored-By: Jan Tojnar <jtojnar@gmail.com>
@worldofpeace worldofpeace force-pushed the worldofpeace:gnome-args branch from 1a335e5 to abe3475 Dec 15, 2019
@worldofpeace worldofpeace merged commit be13df6 into NixOS:master Dec 15, 2019
1 check was pending
1 check was pending
grahamcofborg-eval Checking original out paths
Details
@worldofpeace worldofpeace deleted the worldofpeace:gnome-args branch Dec 15, 2019
@jonringer
Copy link
Contributor

@jonringer jonringer commented Dec 15, 2019

@worldofpeace thanks for doing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.