Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hprotoc: fix broken build #75473

wants to merge 1 commit into from


Copy link

@braydenjw braydenjw commented Dec 11, 2019

Motivation for this change

hprotoc haskell package marked as broken.

Things done

changed dependencies of hprotoc to protocol-buffers_2_4_13

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
Notify maintainers

cc @

@braydenjw braydenjw force-pushed the braydenjw:hprotoc-updates branch from 53fa4b0 to f43fd56 Dec 11, 2019
@@ -940,6 +940,7 @@ default-package-overrides:
- hp2pretty ==0.9
- hpack ==0.31.2
- hpack-dhall ==0.5.2
- hprotoc ==2.4.13

This comment has been minimized.


cdepillabout Dec 11, 2019

See #75449 (comment).

You'll have to create overrides for hprotoc versions in configuration-common.nix (and protocol-buffers-descriptor_2_4_13).

Also, please don't edit the hackage-packages.nix file. This is generated automatically by peti.

Copy link

@cdepillabout cdepillabout left a comment

See above comment.

Copy link

@peti peti left a comment

Copy link
Contributor Author

@braydenjw braydenjw commented Dec 18, 2019

Yes, I'm working on it!

I'm pretty new to Nix and NixOS, so it takes me a bit longer.

Copy link

@peti peti commented Jan 5, 2020

Please feel free to re-submit this fix once the changes suggested by the reviewers have been addressed.

@peti peti closed this Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.