Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.testresources: Move pbr to propagatedBuildInputs #75477

Merged
merged 1 commit into from Dec 11, 2019

Conversation

@andersk
Copy link
Contributor

@andersk andersk commented Dec 11, 2019

Motivation for this change

Since testresources declares Requires-Dist: pbr (>=1.8) and imports pbr.version, any user of testresources also needs to have pbr.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
    • python38Packages.zeep fails to build, but that’s not a regression
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @dotlambda

@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Dec 11, 2019

Can you please change your commit message to pythonPackages.testresources: ... ?
That's a more widely used convention.

Otherwise LGTM.

Since testresources declares `Requires-Dist: pbr (>=1.8)` and imports
`pbr.version`, any user of testresources also needs to have pbr.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
@andersk andersk force-pushed the andersk:testresources branch from 02e2da1 to 1e09e64 Dec 11, 2019
@andersk andersk changed the title python: testresources: Move pbr to propagatedBuildInputs pythonPackages.testresources: Move pbr to propagatedBuildInputs Dec 11, 2019
@andersk
Copy link
Contributor Author

@andersk andersk commented Dec 11, 2019

Can you please change your commit message to pythonPackages.testresources: ... ?

Done.

@worldofpeace worldofpeace merged commit 897a232 into NixOS:master Dec 11, 2019
1 check was pending
1 check was pending
grahamcofborg-eval Checking new out paths
Details
@andersk andersk deleted the andersk:testresources branch Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.