Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.caiman: init at 1.6.4 #75482

Open
wants to merge 4 commits into
base: master
from
Open

pythonPackages.caiman: init at 1.6.4 #75482

wants to merge 4 commits into from

Conversation

@tbenst
Copy link
Contributor

@tbenst tbenst commented Dec 11, 2019

Motivation for this change

Add CaImAn, a Python toolbox for large scale Calcium Imaging data Analysis and behavioral analysis.

The current derivation segfaults, possibly due to improper use of qt5.mkDerivationWith

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@tbenst tbenst requested review from alyssais, FRidh and jonringer as code owners Dec 11, 2019
@tbenst tbenst force-pushed the tbenst:caiman branch from 63aec3a to d0b30db Dec 11, 2019
@tbenst
Copy link
Contributor Author

@tbenst tbenst commented Dec 11, 2019

@ttuegel let me know if you have any ideas? thanks!

bsd3-lbnl = spdx {
spdxId = "BSD-3-Clause-LBNL";
fullName = ''Lawrence Berkeley National Labs BSD variant license'';
};

Comment on lines +103 to +107

This comment has been minimized.

@jonringer

jonringer Dec 11, 2019
Contributor

This should be a separate commit

src = fetchFromGitHub {
owner = "flatironinstitute";
repo = pname;
rev = "v"+version;

This comment has been minimized.

@jonringer

jonringer Dec 11, 2019
Contributor

Suggested change
rev = "v"+version;
rev = "v${version}";
sha256 = "0r3wj5pifhzfa773lnkl7garc18svfvpk5y5p0d0ww4xc2hab1k1";
};

checkInputs = [ unittest2 ];

This comment has been minimized.

@jonringer

jonringer Dec 11, 2019
Contributor

part of std library for python3

Suggested change
checkInputs = [ unittest2 ];
checkInputs = lib.optionals isPy27 [ unittest2 ];
# https://bitbucket.org/lucashnegri/peakutils/issues/36/exp-not-found
doCheck = false;
Comment on lines +23 to +24

This comment has been minimized.

@jonringer

jonringer Dec 11, 2019
Contributor

please try to run as many tests as possible, should have some unit tests

version = "1.3.2";

src = fetchPypi {
pname = "PeakUtils";

This comment has been minimized.

@jonringer

jonringer Dec 11, 2019
Contributor

URLs are case insenstive

Suggested change
pname = "PeakUtils";

src = fetchPypi {
pname = "PeakUtils";
inherit version;

This comment has been minimized.

@jonringer

jonringer Dec 11, 2019
Contributor

Suggested change
inherit version;
inherit version pname;

# doCheck = false;

checkInputs = [ unittest2 ];

This comment has been minimized.

@jonringer

jonringer Dec 11, 2019
Contributor

Suggested change
checkInputs = [ unittest2 ];
checkInputs = lib.optionals isPy27 [ unittest2 ];
@stale
Copy link

@stale stale bot commented Jun 8, 2020

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse.
  3. Ask on the #nixos channel on irc.freenode.net.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.