Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pop-gtk-theme: init at 2019-11-13 #75494

Merged
merged 2 commits into from Dec 19, 2019
Merged

pop-gtk-theme: init at 2019-11-13 #75494

merged 2 commits into from Dec 19, 2019

Conversation

@Elyhaka
Copy link
Contributor

@Elyhaka Elyhaka commented Dec 11, 2019

Motivation for this change

Simply includes a popular theme developed by System76.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

(On recommendation of @worldofpeace on this discourse thread) :

cc @worldofpeace @jtojnar @romildo @c0bw3b

@pbogdan
Copy link
Member

@pbogdan pbogdan commented Dec 11, 2019

Added a few (hopefully helpful) suggestions based on the package I've had kicking around in a local overlay though probably best to defer to folks you CC'ed.
Would personally welcome the inclusion of the package though so thank you for submitting the PR.

Copy link
Contributor

@c0bw3b c0bw3b left a comment

Left a few comments. :)

Your addition to the maintainers list should be a separate commit (and it needs to be before the pkg addition) with the message:
maintainers: add elyhaka

pkgs/data/themes/pop-gtk/default.nix Outdated Show resolved Hide resolved
pkgs/data/themes/pop-gtk/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/data/themes/pop-gtk/default.nix Show resolved Hide resolved
@Elyhaka Elyhaka force-pushed the Elyhaka:pop_gtk_theme branch from c1215f3 to d2413b4 Dec 11, 2019
@Elyhaka Elyhaka force-pushed the Elyhaka:pop_gtk_theme branch 3 times, most recently from e574c63 to 98d17f5 Dec 11, 2019
@Elyhaka Elyhaka changed the title pop-gtk-theme: init at 3.1.2 pop-gtk-theme: init at master_eon HEAD Dec 11, 2019
pkgs/data/themes/pop-gtk/default.nix Outdated Show resolved Hide resolved
@Elyhaka Elyhaka force-pushed the Elyhaka:pop_gtk_theme branch from 98d17f5 to c514c4e Dec 11, 2019
@Elyhaka Elyhaka changed the title pop-gtk-theme: init at master_eon HEAD pop-gtk-theme: init at 2019-11-13 Dec 11, 2019
pkgs/data/themes/pop-gtk/default.nix Outdated Show resolved Hide resolved
pkgs/data/themes/pop-gtk/default.nix Outdated Show resolved Hide resolved
pkgs/data/themes/pop-gtk/default.nix Outdated Show resolved Hide resolved
pkgs/data/themes/pop-gtk/default.nix Outdated Show resolved Hide resolved
pkgs/data/themes/pop-gtk/default.nix Outdated Show resolved Hide resolved
pkgs/data/themes/pop-gtk/default.nix Outdated Show resolved Hide resolved
pkgs/data/themes/pop-gtk/default.nix Outdated Show resolved Hide resolved
pkgs/data/themes/pop-gtk/default.nix Show resolved Hide resolved
@Elyhaka Elyhaka force-pushed the Elyhaka:pop_gtk_theme branch 3 times, most recently from 9d8d946 to b191aff Dec 11, 2019
@Elyhaka Elyhaka requested a review from jtojnar Dec 11, 2019
@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Dec 12, 2019

Here's screenshots of the gtk-widget-factory with the theme on nixos-unstable:
Screenshot from 2019-12-12 05 30 59

Screenshot from 2019-12-12 05 31 16

Haven't checked out the gnome-shell theme or sound theme.

@Elyhaka Elyhaka force-pushed the Elyhaka:pop_gtk_theme branch from b191aff to 8595942 Dec 12, 2019
@Elyhaka Elyhaka force-pushed the Elyhaka:pop_gtk_theme branch from 8595942 to 79850f5 Dec 19, 2019
@Elyhaka
Copy link
Contributor Author

@Elyhaka Elyhaka commented Dec 19, 2019

Pushed update with latest version

@worldofpeace worldofpeace merged commit 83bfedb into NixOS:master Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.