Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

teams: init at 1.2.00.32451 #75505

Merged
merged 1 commit into from Dec 12, 2019
Merged

teams: init at 1.2.00.32451 #75505

merged 1 commit into from Dec 12, 2019

Conversation

@liff
Copy link
Contributor

@liff liff commented Dec 11, 2019

Motivation for this change

A Linux version of Microsoft Teams was released.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notes

It’s somewhat similar to Slack so I was using the slack derivation as a reference.

@Elyhaka
Copy link
Contributor

@Elyhaka Elyhaka commented Dec 11, 2019

When trying to execute this package, It crashes with the following stacktrace :

> teams
A JavaScript error occurred in the main process
Uncaught Exception:
Error: libstdc++.so.6: cannot open shared object file: No such file or directory
    at process.module.(anonymous function) [as dlopen] (ELECTRON_ASAR.js:143:31)
    at Object.Module._extensions..node (internal/modules/cjs/loader.js:722:18)
    at Object.module.(anonymous function) [as .node] (ELECTRON_ASAR.js:152:18)
    at Module.load (internal/modules/cjs/loader.js:602:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:541:12)
    at Function.Module._load (internal/modules/cjs/loader.js:533:3)
    at Module.require (internal/modules/cjs/loader.js:640:17)
    at require (/nix/store/w6w2r130ma4aqcn5inxgnvqcjcv5rqzj-teams-1.2.00.32451/opt/teams/resources/app.asar/external/v8-compile-cache/v8-compile-cache.js:173:28)
    at Object.<anonymous> (/nix/store/w6w2r130ma4aqcn5inxgnvqcjcv5rqzj-teams-1.2.00.32451/opt/teams/resources/app.asar/node_modules/native-utils/index.js:1:173)
    at Object.<anonymous> (/nix/store/w6w2r130ma4aqcn5inxgnvqcjcv5rqzj-teams-1.2.00.32451/opt/teams/resources/app.asar/node_modules/native-utils/index.js:3:3)

The slack derivation seems to address this issue at line 50. I will try to do it locally when I get back from work.

@Elyhaka Elyhaka mentioned this pull request Dec 11, 2019
0 of 10 tasks complete
@liff liff force-pushed the liff:teams/init branch from eaa838e to 34400a2 Dec 12, 2019
@liff
Copy link
Contributor Author

@liff liff commented Dec 12, 2019

Thanks for testing, @Elyhaka. Wonder if I should close this in favor of #75525 though?

@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Dec 12, 2019

They're largely similar, but https://github.com/NixOS/nixpkgs/pull/75525/files uses autoPatchelfHook and wrapGAppsHook which i would've suggested here as well. Though the other is a draft.

@liff liff force-pushed the liff:teams/init branch from 34400a2 to 8d24d9d Dec 12, 2019
@liff
Copy link
Contributor Author

@liff liff commented Dec 12, 2019

Changed to use wrapGAppsHook and autoPatchelfHook, and added some dependencies caught by the latter.

@Elyhaka
Copy link
Contributor

@Elyhaka Elyhaka commented Dec 12, 2019

Great ! It works perfectly for me with this update (no more libstdc++ issue) :)

@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Dec 12, 2019

This expression looks pretty ready @liff 👍

@liff liff force-pushed the liff:teams/init branch from 8d24d9d to 8dbf931 Dec 12, 2019
@liff
Copy link
Contributor Author

@liff liff commented Dec 12, 2019

Since #75525 was closed, should I add @jonringer as a maintainer?

Copy link
Member

@worldofpeace worldofpeace left a comment

LGTM. I will defer to people who actually use the application.

Copy link
Contributor

@aanderse aanderse left a comment

I have tested this PR and the software works as expected. Thank you very much @liff 🎉

@jonringer I'll leave it to you to convince whomever you need to convince that we need a linux port of outlook next 😉 😆

@aanderse aanderse merged commit 06749e4 into NixOS:master Dec 12, 2019
15 checks passed
15 checks passed
teams on aarch64-linux No attempt
Details
teams on x86_64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@jonringer
Copy link
Contributor

@jonringer jonringer commented Dec 12, 2019

not sure why, but i was having problems on my workstation, home computer it works fine though

@jonringer
Copy link
Contributor

@jonringer jonringer commented Dec 12, 2019

I just did a call using this, the audio is very poor, not entire sure why. maybe using libpulseaudio will help remedy that

@jonringer
Copy link
Contributor

@jonringer jonringer commented Dec 12, 2019

also, it was eating my close application, :(

@aanderse
Copy link
Contributor

@aanderse aanderse commented Dec 12, 2019

@jonringer did not use for phone call but used during the day for regular stuff and so far no issues... What is close application?

@jonringer
Copy link
Contributor

@jonringer jonringer commented Dec 12, 2019

If I try to click the X in the upper right-hand corner

@aanderse
Copy link
Contributor

@aanderse aanderse commented Dec 12, 2019

Oh sorry I understand... I was able to click and then I received notification that teams wouldn't exit but remain in tray, as expected.

Maybe I'll try to install on another device 🤔

@jonringer
Copy link
Contributor

@jonringer jonringer commented Dec 12, 2019

The other thing is that, I'm only using lightdm+i3, and no desktop environment. Probably the cause of the wonky issues.

@aanderse
Copy link
Contributor

@aanderse aanderse commented Dec 13, 2019

Yeah definitely might be. I'm on plasma.

I'll test voice call tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.