Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chromium: 78.0.3904.108 -> 79.0.3945.79 #75516

Merged
merged 6 commits into from Dec 15, 2019
Merged

Conversation

@ivan
Copy link
Member

@ivan ivan commented Dec 11, 2019

Motivation for this change

https://chromereleases.googleblog.com/2019/12/stable-channel-update-for-desktop.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Tested chromium on x86_64 NixOS master:
w/ NVIDIA: WebGL, YouTube, audio output, Twitter, Octane 2.0, wasm Google Earth, Widevine OK
w/ radeon: WebGL, YouTube, audio output, Widevine OK

Tested chromiumDev on x86_64 NixOS master:
w/ radeon: WebGL, YouTube, audio output OK

Notify maintainers

cc @bendlas

https://chromereleases.googleblog.com/2019/12/stable-channel-update-for-desktop.html

CVE-2019-13725 CVE-2019-13726 CVE-2019-13727 CVE-2019-13728
CVE-2019-13729 CVE-2019-13730 CVE-2019-13732 CVE-2019-13734
CVE-2019-13735 CVE-2019-13764 CVE-2019-13736 CVE-2019-13737
CVE-2019-13738 CVE-2019-13739 CVE-2019-13740 CVE-2019-13741
CVE-2019-13742 CVE-2019-13743 CVE-2019-13744 CVE-2019-13745
CVE-2019-13746 CVE-2019-13747 CVE-2019-13748 CVE-2019-13749
CVE-2019-13750 CVE-2019-13751 CVE-2019-13752 CVE-2019-13753
CVE-2019-13754 CVE-2019-13755 CVE-2019-13756 CVE-2019-13757
CVE-2019-13758 CVE-2019-13759 CVE-2019-13761 CVE-2019-13762
CVE-2019-13763

The new widevine patch was taken from
https://git.archlinux.org/svntogit/packages.git/plain/trunk/chromium-widevine.patch?h=packages/chromium
@ivan
Copy link
Member Author

@ivan ivan commented Dec 12, 2019

Don't merge, GPU acceleration appears to be broken, at least on NVIDIA and radeon, not sure why.

Problems Detected for Hardware GPU
GPU process was unable to boot: GPU access is disabled due to frequent crashes.
Disabled Features: all
Log Messages
[10254:10254:1212/002809.641113:ERROR:gl_implementation.cc(282)] : Failed to load /nix/store/k5avn68ab928y5im39lhfgq5yhspqs4g-chromium-unwrapped-79.0.3945.79-wv/libexec/chromium/libGLESv2.so: /nix/store/k5avn68ab928y5im39lhfgq5yhspqs4g-chromium-unwrapped-79.0.3945.79-wv/libexec/chromium/libGLESv2.so: cannot open shared object file: No such file or directory
GpuProcessHost: The GPU process exited with code 1024.
[10274:10274:1212/002809.708499:ERROR:gpu_channel_manager.cc(450)] : ContextResult::kFatalFailure: Failed to create shared context for virtualization.
@ivan
Copy link
Member Author

@ivan ivan commented Dec 14, 2019

I have figured out that copying /nix/store/cjvg10incaf6sag8z8v0sganlss4mf8q-libGL-1.2.0/lib/* into libexec/chromium/ makes Chromium's GL support work, now I just need to do something useful instead of that.

@ivan
Copy link
Member Author

@ivan ivan commented Dec 15, 2019

I see that chromium 79 can use GL on NVIDIA and radeon if it is started with --use-gl=egl. I am looking into what changed between 78 -> 79 w.r.t. GLX and EGL. (Note that --use-gl=egl appears to be very buggy on NVIDIA.)

Update 1: everything is working properly on both NVIDIA and radeon with --use-gl=desktop, so there is something going wrong with the default --use-gl=any during initialization.

Update 2: the passthrough command decoder was enabled by default (--use-cmd-decoder=passthrough), and that causes gl_factory.cc to mess with allowed_impls, probably removing desktop from position 0.

@ivan
Copy link
Member Author

@ivan ivan commented Dec 15, 2019

Still testing, please test if you wish but don't merge until I verify that GL works by default and that enableWideVine works.

ivan added 3 commits Dec 14, 2019
This hasn't worked since 2016 (#13983)
and is being removed very soon, per "Q4 2019" in
https://developer.chrome.com/native-client/migration

(It's staying around for "Chrome Apps", but those only run on ChromeOS now.)

earth.google.com users can use https://earth.google.com/web/?beta=1 to get
the wasm version instead of the PNaCl version.
@ivan ivan force-pushed the ivan:chromium-79.0.3945.79 branch from 2326802 to af006f9 Dec 15, 2019
@ofborg ofborg bot requested a review from bendlas Dec 15, 2019
@ivan ivan mentioned this pull request Dec 15, 2019
4 of 10 tasks complete
@ivan
Copy link
Member Author

@ivan ivan commented Dec 15, 2019

My patch appears to have fixed the GL issue. Updated above with my test results.

Please review/merge.

@thefloweringash
Copy link
Member

@thefloweringash thefloweringash commented Dec 15, 2019

I've verified that this builds and runs on aarch64.

@grahamc grahamc merged commit aa4a1b0 into NixOS:master Dec 15, 2019
15 checks passed
15 checks passed
chromium on aarch64-linux Timed out, unknown build status
Details
chromium on x86_64-linux Timed out, unknown build status
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@ivan ivan mentioned this pull request Dec 15, 2019
3 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.