Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] teams: init at 1.2.00.32451 #75525

Closed
wants to merge 1 commit into from
Closed

Conversation

@jonringer
Copy link
Contributor

@jonringer jonringer commented Dec 11, 2019

Motivation for this change

wanted to add the native teams app to nixpkgs

it's able to build, but currently i get this when running it:

strace ./result/share/teams/teams
...
connect(87, {sa_family=AF_UNIX, sun_path="/run/user/1000/pulse/native"}, 110) = 0
sendto(85, "W", 1, MSG_NOSIGNAL, NULL, 0) = -1 ENOTSOCK (Socket operation on non-socket)
write(85, "W", 1)                       = 1
write(85, "W", 1)                       = 1
mmap(NULL, 8392704, PROT_NONE, MAP_PRIVATE|MAP_ANONYMOUS|MAP_STACK, -1, 0) = 0x7f2fb17fb000
mprotect(0x7f2fb17fc000, 8388608, PROT_READ|PROT_WRITE) = 0
clone(child_stack=0x7f2fb1ffaa30, flags=CLONE_VM|CLONE_FS|CLONE_FILES|CLONE_SIGHAND|CLONE_THREAD|CLONE_SYSVSEM|CLONE_SETTLS|CLONE_PARENT_SETTID|CLONE_CHILD_CLEARTID, parent_tid=[32182], tls=0x7f2fb1ffb700, child_tidptr=0x7f2fb1ffb9d0) = 32182
futex(0x55ecc13cd580, FUTEX_UNLOCK_PI_PRIVATE) = 0
futex(0x55ecc14422a8, FUTEX_WAIT_PRIVATE, 0, NULL) = 0
futex(0x55ecc13cd580, FUTEX_LOCK_PI_PRIVATE, NULL) = 0
futex(0x55ecc14422ac, FUTEX_WAIT_PRIVATE, 0, NULL) = 0
futex(0x55ecc13cd580, FUTEX_LOCK_PI_PRIVATE, NULL) = 0
read(58, "", 4)                         = 0
close(58)                               = 0
futex(0x55ecc13cd580, FUTEX_UNLOCK_PI_PRIVATE) = 0
futex(0x55ecc14422a8, FUTEX_WAIT_PRIVATE, 0, NULL) = 0
futex(0x55ecc13cd580, FUTEX_UNLOCK_PI_PRIVATE) = 0
gettid()                                = 32146
futex(0x7f2fb27fb7b8, FUTEX_WAKE_PRIVATE, 2147483647) = 1
futex(0x7f2fb27fb768, FUTEX_WAKE_PRIVATE, 1) = 1
futex(0x7f2f9c001c38, FUTEX_WAKE_PRIVATE, 1) = 1
read(41, "U\251m\377\34X\276\32", 8)    = 8
write(17, "\0", 1)                      = 1
write(17, "\0", 1)                      = 1
+++ killed by SIGTRAP (core dumped) +++
Trace/breakpoint trap (core dumped)

I'm just not really sure where to go from here, I'm assuming it's having some difficulty interacting with pulseaudio then dies, but I'm not really sure.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Dec 11, 2019

@worldofpeace can you think of anything?

@Elyhaka
Copy link
Contributor

@Elyhaka Elyhaka commented Dec 11, 2019

@jonringer I have been trying to package teams this morning, and I ended up in the same situation. (Same output in the strace). I've later found #75505 and after fixing it (commented it there), it started to work. I'm not really sure why it works with this one, though.

EDIT : I do not think it is related to pulseaudio, I compared the strace with one with the ArchLinux AUR, and it was the same output on the puleaudio part.

@aanderse
Copy link
Contributor

@aanderse aanderse commented Dec 11, 2019

Looking forward to this

BTW @jonringer what do you use for O365 (specifically mail, though interested in others too), assuming you run NixOS as your daily driver.

@JohnAZoidberg
Copy link
Member

@JohnAZoidberg JohnAZoidberg commented Dec 11, 2019

what do you use for O365 (specifically mail, though interested in others too)

outlook.office.com is pretty good

I'm really excited for this! I'm glad MS and my company are switching from Skype to Teams.

wrapProgram $out/share/${binaryName}/${binaryName} \
"''${gappsWrapperArgs[@]}" \
--prefix XDG_DATA_DIRS : "${gtk3}/share/gsettings-schemas/${gtk3.name}/" \
Comment on lines +46 to +49

This comment has been minimized.

@worldofpeace

worldofpeace Dec 11, 2019
Member

if gtk3, glib, and wrapGAppsHook are present in the proper *inputs, this is completely unnecessary.
wrapGAppsHook will wrap automatically, and glib setup-hook will collect gtk3's gsettings-schemas directed passed to wrapGAppsHook.

@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Dec 12, 2019

Yea, i use the O365 browser versions. But having a native one is nicer for responsiveness and better notifications

@liff liff mentioned this pull request Dec 12, 2019
4 of 10 tasks complete
@aanderse
Copy link
Contributor

@aanderse aanderse commented Dec 12, 2019

Yea, i use the O365 browser versions. But having a native one is nicer for responsiveness and better notifications

@jonringer rough. That is what I'm currently stuck on too ☹️
@JohnAZoidberg we'll have to agree to disagree on this point, though mostly because of calendar notifications.

@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Dec 12, 2019

I think we'll go with #75505

@jonringer jonringer deleted the jonringer:add-teams branch Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.