Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xandikos: init at 0.1.0 #75532

Merged
merged 1 commit into from Dec 21, 2019
Merged

xandikos: init at 0.1.0 #75532

merged 1 commit into from Dec 21, 2019

Conversation

@0x4A6F
Copy link
Contributor

@0x4A6F 0x4A6F commented Dec 11, 2019

Motivation for this change

Add xandikos package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @matthiasbeyer taking over xandikos from #31096

@offlinehacker
Copy link
Contributor

@offlinehacker offlinehacker commented Dec 12, 2019

Everything else looks good to me

@0x4A6F 0x4A6F force-pushed the 0x4A6F:master-xandikos branch from a4d939f to 43f29d6 Dec 12, 2019
pkgs/servers/xandikos/default.nix Outdated Show resolved Hide resolved
@0x4A6F 0x4A6F force-pushed the 0x4A6F:master-xandikos branch from 43f29d6 to 89674bd Dec 16, 2019
Copy link
Contributor

@matthiasbeyer matthiasbeyer left a comment

Diff looks good to me.

@Ma27
Ma27 approved these changes Dec 21, 2019
Copy link
Member

@Ma27 Ma27 left a comment

Built and tested locally 👍

@Ma27 Ma27 merged commit 68dfdc2 into NixOS:master Dec 21, 2019
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
xandikos on aarch64-linux Success
Details
xandikos on x86_64-linux Success
Details
@matthiasbeyer
Copy link
Contributor

@matthiasbeyer matthiasbeyer commented Dec 21, 2019

Nice

@0x4A6F 0x4A6F deleted the 0x4A6F:master-xandikos branch Dec 22, 2019
@0x4A6F 0x4A6F restored the 0x4A6F:master-xandikos branch Dec 22, 2019
@0x4A6F 0x4A6F mentioned this pull request Dec 22, 2019
4 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.