Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kdeApplications: kcalcore dependencies fix #75533

Merged
merged 2 commits into from Dec 15, 2019

Conversation

@nyanloutre
Copy link
Member

@nyanloutre nyanloutre commented Dec 11, 2019

Motivation for this change

kcalcore seems to be abandoned in favor of kcalendarcore

I still have errors compiling kitinerary but could not identify whout would cause that. As a consequence kdepim-addons is not building either.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

nyanloutre added 2 commits Dec 11, 2019
@nyanloutre nyanloutre requested a review from ttuegel as a code owner Dec 11, 2019
@ofborg ofborg bot added the 6.topic: qt/kde label Dec 11, 2019
@nyanloutre
Copy link
Member Author

@nyanloutre nyanloutre commented Dec 11, 2019

@GrahamcOfBorg build kdeApplications.kitinerary

@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Dec 12, 2019

@nyanloutre we updated poppler and it broke it, see KDE/kitinerary@5e001bf.
That patch doesn't apply though, but the conflict is just an include.
But even after this it doesn't build because other fixes need to be applied related to poppler.

Perhaps we can just override src to the latest released version.

@nyanloutre
Copy link
Member Author

@nyanloutre nyanloutre commented Dec 13, 2019

We can also update the KDE apps directly to 19.12: https://kde.org/announcements/releases/19.12/

@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Dec 13, 2019

We can also update the KDE apps directly to 19.12: https://kde.org/announcements/releases/19.12/

Sounds good, this fix isn't blocking staging next is it though?

@nyanloutre
Copy link
Member Author

@nyanloutre nyanloutre commented Dec 13, 2019

I don't think this fix should block staging next as the only packages failing to build are kitinerary and kdepim-addons which are not used in any other packages

@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Dec 13, 2019

I don't think this fix should block staging next as the only packages failing to build are kitinerary and kdepim-addons which are not used in any other packages

Ah ok. I thought there were failures in staging-next that broke the plasma5 test in deps chain.

@FRidh FRidh merged commit 2abd0a5 into NixOS:staging-next Dec 15, 2019
17 checks passed
17 checks passed
kdeApplications.kitinerary on aarch64-linux Failure
Details
kdeApplications.kitinerary on x86_64-linux Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
kdeFrameworks.kcalendarcore on aarch64-linux Success
Details
kdeFrameworks.kcalendarcore on x86_64-linux Success
Details
@nyanloutre nyanloutre deleted the nyanloutre:akonadi_search_fix branch Dec 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.