Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-adfs: 1.19.1 -> 1.20.0; fix build #75536

Merged
merged 1 commit into from Dec 13, 2019
Merged

aws-adfs: 1.19.1 -> 1.20.0; fix build #75536

merged 1 commit into from Dec 13, 2019

Conversation

@cko
Copy link
Member

@cko cko commented Dec 11, 2019

Motivation for this change

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @bhipple

@cko cko requested review from FRidh and jonringer as code owners Dec 11, 2019
@ofborg ofborg bot added the 6.topic: python label Dec 11, 2019
@ofborg ofborg bot requested a review from bhipple Dec 11, 2019
Copy link
Contributor

@jonringer jonringer left a comment

commit should be:

pythonPackages.aws-adfs: 1.19.1 -> 1.20.0; fix build

otherwise LGTM

@jonringer
Copy link
Contributor

@jonringer jonringer commented Dec 12, 2019

@GrahamcOfBorg build pythonPackages.aws-adfs

@cko cko force-pushed the cko:aws-adfs branch from b8b7341 to e5edba0 Dec 12, 2019
@cko
Copy link
Member Author

@cko cko commented Dec 12, 2019

@jonringer I fixed the commit message. I think the failing builds for Python 2.7 can be ignored as it will be EOL at the end of the year anyway - they relate to dependency versions not matching.

@jonringer
Copy link
Contributor

@jonringer jonringer commented Dec 13, 2019

I would either disable python2, or freeze lxml to <4.4.0 for python2, disabling for python2 would be easier

builder for '/nix/store/sc2slb55b18ac0q9x8sina3brla6sf7p-python2.7-aws-adfs-1.20.0.drv' failed with exit code 1; last 10 log lines:
  adding 'aws_adfs-1.20.0.dist-info/RECORD'
  removing build/bdist.linux-x86_64/wheel
  Finished executing setuptoolsBuildPhase
  installing
  Executing pipInstallPhase
  /build/aws-adfs-1.20.0/dist /build/aws-adfs-1.20.0
  DEPRECATION: Python 2.7 will reach the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 won't be maintained after that date. A future version of pip will drop support for Python 2.7. More details about Python 2 support in pip, can be found at https://pip.pypa.io/en/latest/development/release-process/#python-2-support
  Processing ./aws_adfs-1.20.0-py2-none-any.whl
  ERROR: Could not find a version that satisfies the requirement lxml<4.4.0; python_version < "3.5" (from aws-adfs==1.20.0) (from versions: none)
  ERROR: No matching distribution found for lxml<4.4.0; python_version < "3.5" (from aws-adfs==1.20.0)
@cko cko force-pushed the cko:aws-adfs branch from e5edba0 to 826f007 Dec 13, 2019
@cko
Copy link
Member Author

@cko cko commented Dec 13, 2019

@jonringer I fixed it.

@ofborg ofborg bot added the 8.has: clean-up label Dec 13, 2019
Copy link
Contributor

@jonringer jonringer left a comment

LGTM

python38 failure likely an upstream issue

https://github.com/NixOS/nixpkgs/pull/75536
1 package failed to build:
python38Packages.aws-adfs

1 package were built:
aws-adfs
@jonringer
Copy link
Contributor

@jonringer jonringer commented Dec 13, 2019

@GrahamcOfBorg build aws-adfs

@jonringer jonringer merged commit 7f2e8f6 into NixOS:master Dec 13, 2019
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
aws-adfs on aarch64-linux Success
Details
aws-adfs on x86_64-darwin Success
Details
aws-adfs on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.