Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.send2trash: fix hash #75538

Merged
merged 1 commit into from Dec 12, 2019
Merged

Conversation

@marsam
Copy link
Contributor

@marsam marsam commented Dec 12, 2019

Motivation for this change

Fixes #75514

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@marsam marsam requested review from FRidh and jonringer as code owners Dec 12, 2019
@marsam
Copy link
Contributor Author

@marsam marsam commented Dec 12, 2019

@GrahamcOfBorg build pythonPackages.send2trash

@jonringer
Copy link
Contributor

@jonringer jonringer commented Dec 12, 2019

thanks, looks like I forgot to update hash. must have been working due to local cache. My bad

@jonringer jonringer merged commit 7825cde into NixOS:master Dec 12, 2019
4 of 6 checks passed
4 of 6 checks passed
grahamcofborg-eval Beginning Evaluations
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
pythonPackages.send2trash on aarch64-linux Success
Details
pythonPackages.send2trash on x86_64-linux Success
Details
Copy link
Contributor

@jonringer jonringer left a comment

of borg was able to build ilt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.