Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jd-gui: 1.4.0 -> 1.6.5 #75546

Merged
merged 1 commit into from Dec 14, 2019
Merged

jd-gui: 1.4.0 -> 1.6.5 #75546

merged 1 commit into from Dec 14, 2019

Conversation

@averelld
Copy link
Contributor

@averelld averelld commented Dec 12, 2019

Motivation for this change

Automatic update fails, upstream updated the build process, and got rid of a gradle 2 dependency in the process.
According to #58528 (comment) this could mean gradle_2 can be removed (And probably 3 as well).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@liff
Copy link
Contributor

@liff liff commented Dec 13, 2019

Built and tested, works as expected.

@averelld averelld force-pushed the averelld:jdgui-update branch 2 times, most recently from 9428340 to dbdee74 Dec 13, 2019

outputHashAlgo = "sha256";
outputHashMode = "flat";
outputHash = "16wh7cmkhi305i3x3l8qkmcy9z9l67q3rqaxdsy96gih9gbmmzb5";

This comment has been minimized.

@Mic92

Mic92 Dec 13, 2019
Contributor

This seems a bit flacky. Does it not break the checksum, when a new javac changes the way the byte code is compiled?

This comment has been minimized.

@averelld

averelld Dec 13, 2019
Author Contributor

Yes, unfortunately. Everything is back to the old approach.

@averelld averelld force-pushed the averelld:jdgui-update branch from dbdee74 to d576beb Dec 13, 2019
Averell Dalton
@averelld averelld force-pushed the averelld:jdgui-update branch from d576beb to bc5f25a Dec 13, 2019
@averelld averelld mentioned this pull request Dec 13, 2019
4 of 10 tasks complete
@Mic92 Mic92 merged commit fbfd77b into NixOS:master Dec 14, 2019
15 checks passed
15 checks passed
jd-gui on aarch64-linux Unexpected error: command failed with exit code 102
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
jd-gui on x86_64-linux Success
Details
@petabyteboy petabyteboy mentioned this pull request Jan 10, 2020
4 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.