Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

step-ca: init at 0.13.3 #75548

Merged
merged 1 commit into from Jan 3, 2020
Merged

step-ca: init at 0.13.3 #75548

merged 1 commit into from Jan 3, 2020

Conversation

@CMCDragonkai
Copy link
Member

@CMCDragonkai CMCDragonkai commented Dec 12, 2019

Motivation for this change

This adds step-ca, a certificate server that goes along with step-cli. This is already available in nixpkgs: https://github.com/NixOS/nixpkgs/tree/master/pkgs/tools/security/step-cli

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @xfix

@CMCDragonkai CMCDragonkai force-pushed the MatrixAI:step-ca branch from 6254125 to 6d7e92f Dec 12, 2019
@CMCDragonkai
Copy link
Member Author

@CMCDragonkai CMCDragonkai commented Dec 12, 2019

Note that the next prerelease stops using deps and uses go 2 modules. So will require a better deps generator.

@CMCDragonkai CMCDragonkai force-pushed the MatrixAI:step-ca branch from 6d7e92f to 5015d2e Dec 12, 2019
@CMCDragonkai
Copy link
Member Author

@CMCDragonkai CMCDragonkai commented Dec 12, 2019

Should this be put into pkgs/servers instead?

@CMCDragonkai
Copy link
Member Author

@CMCDragonkai CMCDragonkai commented Dec 12, 2019

This should be ready to go.

@CMCDragonkai CMCDragonkai force-pushed the MatrixAI:step-ca branch from 59cb30b to 84163bf Dec 16, 2019
@CMCDragonkai
Copy link
Member Author

@CMCDragonkai CMCDragonkai commented Dec 16, 2019

Ready to go if people feel that step-ca is in the right place.

@CMCDragonkai CMCDragonkai requested a review from c0bw3b Dec 16, 2019
@CMCDragonkai
Copy link
Member Author

@CMCDragonkai CMCDragonkai commented Dec 23, 2019

Status update?

@CMCDragonkai
Copy link
Member Author

@CMCDragonkai CMCDragonkai commented Jan 3, 2020

@c0bw3b
c0bw3b approved these changes Jan 3, 2020
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Pardon, I'm just coming back from some holidays :)

@c0bw3b c0bw3b merged commit af2046d into NixOS:master Jan 3, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
step-ca on aarch64-linux Success
Details
step-ca on x86_64-linux Success
Details
@CMCDragonkai CMCDragonkai deleted the MatrixAI:step-ca branch Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.