Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.sympy: add antlr4 dep #75549

Closed
wants to merge 1 commit into from

Conversation

@matthuszagh
Copy link
Contributor

@matthuszagh matthuszagh commented Dec 12, 2019

antlr is necessary for sympy to be able to parse latex input (see the bottom of this page).

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

antlr is necessary for sympy to be able to parse latex input.
@matthuszagh matthuszagh requested review from FRidh and jonringer as code owners Dec 12, 2019
@matthuszagh matthuszagh mentioned this pull request Dec 12, 2019
2 of 10 tasks complete
@ofborg ofborg bot added the 6.topic: python label Dec 12, 2019
@ofborg ofborg bot requested review from lovek323 and timokau Dec 12, 2019
@FRidh
Copy link
Member

@FRidh FRidh commented Dec 12, 2019

Is it a mandatory dependency (that is, it is in install_requires), or an optional dependency?

@matthuszagh
Copy link
Contributor Author

@matthuszagh matthuszagh commented Dec 13, 2019

Fair point, only necessary if you need latex parsing (not sure if it's used anywhere else). Shall I change it to an option defaulting to false?

@matthuszagh
Copy link
Contributor Author

@matthuszagh matthuszagh commented Dec 14, 2019

Happy to close this if you don't feel it's necessary since it's an optional dependency.

@jonringer
Copy link
Contributor

@jonringer jonringer commented Dec 14, 2019

unfortunately there's a mismatch in abstractions between nix and python packages, in which this scenario doesn't have a great solution.

The most proper course of action would be include the related antlr4 package in the environment in which you need it.

@matthuszagh
Copy link
Contributor Author

@matthuszagh matthuszagh commented Dec 14, 2019

Sounds good, thanks for the response @jonringer. Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.