Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libgpod: drop pygobject2 #75555

Merged
merged 2 commits into from Dec 17, 2019
Merged

Conversation

@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Dec 12, 2019

Motivation for this change

Let's drop libgpod using pygobject2.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@worldofpeace worldofpeace added this to To do in Picking up garbage via automation Dec 12, 2019
@worldofpeace worldofpeace requested review from jtojnar and FRidh Dec 12, 2019
@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Dec 12, 2019

Multi-output as well.
Upstream claims it doesn't work gpodder/gpodder#706.
@worldofpeace worldofpeace force-pushed the worldofpeace:libgpod-python2-byehun branch from 81f6333 to d206f31 Dec 12, 2019
@worldofpeace worldofpeace changed the title libgpod: drop python2 libgpod: drop pygobject2 Dec 12, 2019
@worldofpeace worldofpeace merged commit 6ea98c1 into NixOS:master Dec 17, 2019
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
gpodder, libgpod on aarch64-linux Success
Details
gpodder, libgpod on x86_64-darwin Success
Details
gpodder, libgpod on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Picking up garbage automation moved this from To do to Done Dec 17, 2019
@worldofpeace worldofpeace deleted the worldofpeace:libgpod-python2-byehun branch Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.