Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

teensyduino: add missing dependencies for teensy-loader #75560

Closed
wants to merge 1 commit into from

Conversation

@cawilliamson
Copy link
Contributor

@cawilliamson cawilliamson commented Dec 12, 2019

Motivation for this change

The teensy-loader (./share/arduino/hardware/tools/teensy) was not linked with the full list of dependencies that it needs. Thus it didn't start when called by the Arduino (Teensyduino) UI to actually push code to the device.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @antono @auntie @robberer @bjornfor @bergey

Copy link
Contributor

@etu etu left a comment

udev and cairo needs to be added to the top of the file as inputs to the function.

@etu
Copy link
Contributor

@etu etu commented Dec 13, 2019

This refers to #75537

@witchof0x20
Copy link
Contributor

@witchof0x20 witchof0x20 commented Jan 25, 2020

This patch, with udev and cairo added to the top, fixed my issue. Thank you!

@witchof0x20
Copy link
Contributor

@witchof0x20 witchof0x20 commented Jan 25, 2020

One issue I ran into: Though most things work, the teensy restart program fails with libudev.so.1: cannot open shared object file: No such file or directory

@rehno-lindeque
Copy link
Contributor

@rehno-lindeque rehno-lindeque commented Mar 10, 2020

This can be closed now as this was merged in #81156

@bjornfor bjornfor closed this Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.