Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hivemind: 1.0.4 -> 1.0.6 #75567

Merged
merged 1 commit into from Dec 14, 2019
Merged

hivemind: 1.0.4 -> 1.0.6 #75567

merged 1 commit into from Dec 14, 2019

Conversation

@duijf
Copy link
Contributor

@duijf duijf commented Dec 12, 2019

Motivation for this change

The hivemind application has a new version. Changelog excerpt:

Build the new version with: nix-build -A hivemind

v1.0.6
Critical fix for Linux

v1.0.5
Loading environment variables from .env file;
Hivemind options can be set with environment variables;
--no-prefix flag.

Build the new version with: nix-build -A hivemind

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @sveitser

Laurens Duijvesteijn
@ruuda
ruuda approved these changes Dec 12, 2019
Copy link
Contributor

@ruuda ruuda left a comment

I built the package and tested running an application with it on non-NixOS.

@sveitser
Copy link
Contributor

@sveitser sveitser commented Dec 13, 2019

Build and runs fine for me on NixOS. LGTM.

Copy link
Contributor

@jonringer jonringer left a comment

LGTM
executable shows usage

[3 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/75567
1 package were built:
hivemind
@jonringer
Copy link
Contributor

@jonringer jonringer commented Dec 14, 2019

@GrahamcOfBorg build hivemind

@jonringer jonringer merged commit 88c6f13 into NixOS:master Dec 14, 2019
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
hivemind on aarch64-linux Success
Details
hivemind on x86_64-darwin Success
Details
hivemind on x86_64-linux Success
Details
@duijf duijf deleted the duijf:hivemind-v1.0.6 branch Dec 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.