Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

root: 6.12.06 -> 6.18.04 #75569

Merged
merged 1 commit into from Dec 14, 2019
Merged

root: 6.12.06 -> 6.18.04 #75569

merged 1 commit into from Dec 14, 2019

Conversation

@veprbl
Copy link
Member

@veprbl veprbl commented Dec 12, 2019

Motivation for this change

To provide a more modern version of ROOT.

cc @yipengsun who pointed out the issue to me

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Also switch to python3.
Copy link
Contributor

@jonringer jonringer left a comment

diff LGTM
most executables show usage (didn't test them all)

[6 built (1 failed), 240 copied (194.9 MiB), 70.9 MiB DL]
error: build of '/nix/store/8h475w2jgvbj88svpig8prbyxq6xkiak-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/75569
2 package failed to build:
python27Packages.root_numpy python27Packages.rootpy

5 package were built:
fastnlo hepmc3 mcgrid root yoda-with-root

I'll open up a different PR to fix the packages broken on master

builder for '/nix/store/3ljrk9zfagj8zynxicvmz9v8vdfikdli-python2.7-root_numpy-4.8.0.drv' failed with exit code 1; last 10 log lines:
  setting SOURCE_DATE_EPOCH to timestamp 1547045302 of file root_numpy-4.8.0/setup.cfg
  patching sources
  configuring
  no configure script, doing nothing
  building
  Executing setuptoolsBuildPhase
  Traceback (most recent call last):
    File "nix_run_setup", line 3, in <module>
      import setuptools
  ImportError: No module named setuptools
@jonringer
Copy link
Contributor

@jonringer jonringer commented Dec 14, 2019

@GrahamcOfBorg build fastnlo hepmc3 mcgrid root yoda-with-root

@jonringer jonringer mentioned this pull request Dec 14, 2019
5 of 10 tasks complete
@jonringer
Copy link
Contributor

@jonringer jonringer commented Dec 14, 2019

darwin timeout due to llvm rebuild

@jonringer jonringer merged commit b6d8873 into NixOS:master Dec 14, 2019
19 checks passed
19 checks passed
fastnlo, hepmc3, mcgrid, root, yoda-with-root on x86_64-darwin Timed out, unknown build status
Details
root on x86_64-darwin Timed out, unknown build status
Details
Evaluation Performance Report Evaluator Performance Report
Details
fastnlo, hepmc3, mcgrid, root, yoda-with-root on aarch64-linux Success
Details
fastnlo, hepmc3, mcgrid, root, yoda-with-root on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
root on aarch64-linux Success
Details
root on x86_64-linux Success
Details
@veprbl
Copy link
Member Author

@veprbl veprbl commented Dec 14, 2019

I'll open up a different PR to fix the packages broken on master

I appreciate this a lot. However, I think the time has come to remove python27Packages.root_numpy and python27Packages.rootpy packages. The first one is replaced by pythonPackages.uproot аnd there are some developments to do that in ROOT itself, it seems. The second one could work without the root_numpy dependency, but, I assume, the package has become a bit stale, and, judging by its issue tracker, it will not work with ROOT 6.18

@jonringer
Copy link
Contributor

@jonringer jonringer commented Dec 14, 2019

no problem :), it was an easy fix.

For deprecating the package, feel free to do what you would like :). Python2 is EOL in 2 weeks anyway, I just don't like seeing failure noise in nix-review

@veprbl
Copy link
Member Author

@veprbl veprbl commented Dec 14, 2019

Well, I don't know what the plan is. But if it is to just crash all of python2 infrastructure in nixpkgs, then now is the good time to drop these.

@jonringer
Copy link
Contributor

@jonringer jonringer commented Dec 14, 2019

it will likely be up to @FRidh as he probably has more insight than I do. My assumption would be to let it ride until a major CVE is announced, then mark it as vulnerable or remove it entirely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.