Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xrdp: enable vsock connections #75581

Closed
wants to merge 1 commit into from
Closed

xrdp: enable vsock connections #75581

wants to merge 1 commit into from

Conversation

@sboehler
Copy link

@sboehler sboehler commented Dec 12, 2019

(first time contributor)

If NixOS is run as a Hyper-V guest, enabling vsock transport allows
to use enhanced session mode when connecting from the host operating
system.

Modification is ported from Microsoft's Ubuntu scripts:
https://github.com/microsoft/linux-vm-tools/blob/4dcc278f842ef1de4cc2c7b24ecb1c048415ff07/ubuntu/18.04/install.sh#L47-L55

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @volth

@sboehler sboehler marked this pull request as ready for review Dec 12, 2019
@ofborg ofborg bot requested a review from volth Dec 12, 2019
@volth
volth approved these changes Dec 12, 2019
Copy link
Contributor

@volth volth left a comment

looks good.
but I have not tested

Copy link
Contributor

@jonringer jonringer left a comment

otherwise LGTM

Copy link
Contributor

@jonringer jonringer left a comment

didn't test, but LGTM

If NixOS is run as a Hyper-V guest, enabling vsock transport allows
to use enhanced session mode when connecting from the host operating
system.

Modification is ported from Microsoft's Ubuntu scripts:
https://github.com/microsoft/linux-vm-tools/blob/4dcc278f842ef1de4cc2c7b24ecb1c048415ff07/ubuntu/18.04/install.sh#L47-L55
@sboehler sboehler force-pushed the sboehler:xrdp-vsock branch from 640cd85 to 4b29020 Dec 13, 2019
@sboehler
Copy link
Author

@sboehler sboehler commented Dec 13, 2019

I noticed that setting the default to virtualisation.hypervGuest.enable might break the setup of people who do use RDP but have not set up enhanceded session mode at the moment (some setup is needed on the windows side of things for vsock to work). Therefore false is a much safer default.

@ofborg ofborg bot requested a review from volth Dec 13, 2019
@sboehler sboehler closed this Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.