Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R: 3.6.1 -> 3.6.2 #75587

Closed
wants to merge 1 commit into from
Closed

R: 3.6.1 -> 3.6.2 #75587

wants to merge 1 commit into from

Conversation

@jabranham
Copy link
Contributor

@jabranham jabranham commented Dec 13, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jabranham jabranham requested a review from peti as a code owner Dec 13, 2019
@ofborg ofborg bot requested a review from timokau Dec 13, 2019
@timokau
Copy link
Member

@timokau timokau commented Dec 13, 2019

Please look into the aarch64 ofBorg failure.

peti added a commit to peti/nixpkgs that referenced this pull request Dec 13, 2019
@peti
Copy link
Member

@peti peti commented Dec 13, 2019

Cherry-picked into r-updates as df07230. Test builds are running at https://hydra.nixos.org/jobset/nixpkgs/r-updates.

@peti peti mentioned this pull request Dec 13, 2019
2 of 10 tasks complete
@jabranham
Copy link
Contributor Author

@jabranham jabranham commented Dec 15, 2019

This is the error on the aarch build: running code in 'reg-tests-1d.R' ...make[3]: *** [Makefile.common:106: reg-tests-1d.Rout] Error 1, which isn't especially useful without access to the reg-tests-1d.Rout file. I don't have an aarch64 machine to test this on. Does ofborg store that file somewhere I'm missing?

@timokau
Copy link
Member

@timokau timokau commented Dec 16, 2019

Not currently. That is why I opened #49378 some while ago. Unfortunately that wasn't accepted. Maybe you can cherry-pick it into this PR and look at the error ofBorg generates.

@peti peti closed this in 7af84af Dec 16, 2019
@jabranham jabranham deleted the jabranham:r branch Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.