Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amazon-ecs-cli: add darwin #75588

Merged
merged 1 commit into from Dec 16, 2019
Merged

amazon-ecs-cli: add darwin #75588

merged 1 commit into from Dec 16, 2019

Conversation

@gege251
Copy link
Contributor

@gege251 gege251 commented Dec 13, 2019

Motivation for this change

amazon-ecs-cli is not compatible with Mac OS

Things done

Fetching from the correct url on darwin systems.
https://github.com/aws/amazon-ecs-cli

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@gege251
Copy link
Contributor Author

@gege251 gege251 commented Dec 15, 2019

@marsam Thank you for the review!

@gege251 gege251 requested a review from marsam Dec 16, 2019
@marsam marsam force-pushed the gege251:darwin-amazon-ecs-cli branch from 4003ad6 to a1c8ec7 Dec 16, 2019
@marsam
Copy link
Contributor

@marsam marsam commented Dec 16, 2019

Sorry for the delay, thank you for your contribution. I've made a minor change, I hope you don't mind
@GrahamcOfBorg build amazon-ecs-cli

@marsam marsam merged commit 303c944 into NixOS:master Dec 16, 2019
15 checks passed
15 checks passed
amazon-ecs-cli on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
amazon-ecs-cli on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@gege251
Copy link
Contributor Author

@gege251 gege251 commented Dec 17, 2019

@marsam Not at all! Thank you!
This is my first contribution to Nix, and there are a lot of things I still don't know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.